Skip to content

Conversation -1 instead of _end #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2025
Merged

Conversation -1 instead of _end #1197

merged 2 commits into from
May 31, 2025

Conversation

martindevans
Copy link
Member

Using -1 for start/end positions in Conversation. This eliminates the possibility of KV cache leaks due to bugs with _end getting out of sync.

@martindevans
Using -1 for start/end positions in Conversation. This eliminate …
9e59105 
…the possibility of KV cache leaks due to bugs with `_end` getting out of sync.
dpmm99
dpmm99 reviewed May 31, 2025
View reviewed changes
@martindevans martindevans requested a review from dpmm99 May 31, 2025 23:12
dpmm99
dpmm99 approved these changes May 31, 2025
View reviewed changes
Copy link
Contributor

@dpmm99 dpmm99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better! :)

@martindevans martindevans merged commit e52f5ef into SciSharp:master May 31, 2025
6 checks passed
@martindevans martindevans deleted the batch_executor_neg_one branch May 31, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dpmm99 dpmm99 dpmm99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martindevans @dpmm99