Skip to content

Conversation -1 instead of _end #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

Conversation -1 instead of _end #1197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e59105
Using `-1` for start/end positions in `Conversation`. This eliminate …
martindevans May 31, 2025
3bfedda
Fixed `Remove` comment
martindevans May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LLama/Batched/Conversation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
_disposed = true;

// Remove this conversation from the KV cache
Executor.Context.NativeHandle.KvCacheRemove(ConversationId, 0, _end);
Executor.Context.NativeHandle.KvCacheRemove(ConversationId, -1, -1);

// Prevent finalizer from running
GC.SuppressFinalize(this);
Expand Down Expand Up @@ -410,7 +410,7 @@
}

/// <summary>
/// Removes all tokens starting from the given position
/// Removes <see cref="count"/> tokens starting from <see cref="start"/>

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (linux-release) 

XML comment has cref attribute 'start' that could not be resolved

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (linux-release) 

XML comment has cref attribute 'count' that could not be resolved

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (windows-release) 

XML comment has cref attribute 'start' that could not be resolved

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (windows-release) 

XML comment has cref attribute 'count' that could not be resolved

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (osx-release) 

XML comment has cref attribute 'start' that could not be resolved

Check warning on line 413 in LLama/Batched/Conversation.cs

View workflow job for this annotation

GitHub Actions / Test (osx-release) 

XML comment has cref attribute 'count' that could not be resolved
/// </summary>
/// <param name="start">Start position (inclusive)</param>
/// <param name="count">Number of tokens</param>
Expand Down
Loading