feat: add experimental auto-download support. #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to work on osx. I think it should be clearly described at some point how the cache is managed and where is located by default: 
|
4 tasks
SanftMonster
force-pushed
the
experimental-auto-download
branch
from
54efc4a to
486bcc6
Compare
|
Merge this PR now since this feature is only included in the experimental package. However, the introduction of this feature in the master branch will be delayed indefinitely. Before figuring a good way to deal with the security issue, this feature will be kept only in the experimental package. The documentation of the description of its usages and cache will be added in a separate PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements #670 and should only be merged after #688
It puts all the logics of auto-download in a new package
LLama.Exeprimental. Thus we don't need to rush for making the decision that whether it should be added to the main package or as a separate package. Instead we could listen from the users first.It works fine for me on my windows. I'll appreciate it if anyone would like to help on Linux and MAC!
TODO
How to test it
Comment all the content in LLama/LLamaSharp.Runtime.targets and run the examples with auto-download enabled. It's better to enable the full logs (though in a bit mess now).