add location argument to mesh.coords #6055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 90 90
Lines 22996 22991 -5
Branches 5032 5030 -2
=======================================
- Hits 20642 20638 -4
Misses 1623 1623
+ Partials 731 730 -1 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
trexfeathers
requested changes
Jul 17, 2024
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Some fairly wide scope things for you. I will hold off more detailed reviewing until we have some conclusions.
Thanks!
* main: Quieter datum warning (SciTools#6050) Allow MeshCoord to have a coord-system (SciTools#6016) Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
trexfeathers
previously requested changes
Jul 19, 2024
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Beautiful work @stephenworsley - neater, less confusing, and true to the original philosophy of identical signatures all eventually passing down to the filters() method.
* main: Rename `Mesh` to `MeshXY` (SciTools#6056) Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063) # Conflicts: # docs/src/whatsnew/latest.rst
pp-mo
approved these changes
Jul 19, 2024
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
All good I think, just needs an approval.
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 21, 2024
* upstream/main: Updated environment lockfiles (SciTools#6029) Pin matplotlib != 3.9.1 (SciTools#6065) add location argument to mesh.coords (SciTools#6055) Doctest compatibility with GeoVista v0.5. (SciTools#6064) Rename `Mesh` to `MeshXY` (SciTools#6056) Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Closes #5993