V4.0 Lucene 4.8.0-beta00017 breaking changes

[DevAndersen]

I've attempted to address the problems raised in #401, relating to breaking changes in the version 4.8.0-beta00017 Lucene packages.

The code now compiles with the beta00017 packages, utilizing the SnapshotDirectoryTaxonomyIndexWriterFactory class from Lucene, however there are three unit tests that now fail which previously succeeded. These are:

• GivenASyncedLocalIndex_WhenTriggered_ThenSyncedBackToMainIndex
• GivenASyncedLocalIndex_ThenSyncedBackToMainIndexOnSchedule
• GivenAMainIndex_WhenReplicatedLocally_TheLocalIndexIsPopulated

The problem lies in the changed implementation of the ReplicateIndex method, as I have been unable to figure out exactly how to get it working properly. It now throws System.InvalidOperationException: 'No index commit to snapshot', which results in the method returning early before it can fully completing the work of the method.

I hope I've done a bit of the work, perhaps someone else more knowledgeable can fix up the remaining outstanding problems.

[Shazwazza]

I will get to this soon, there's been some changes in v3 that were required, also relating to replicator, etc... Still waiting on community feedback but once that is shipped, the re-merge of v3 - v4 with additional fixes will be in place.

[skttl]

I tried building this PR, and replaced it on an existing site with the v4.0.0-beta-1 (in order to be able to upgrade Umbraco to 13.7.1). Seems to work ok!

[dillorscroft]

I tried building this PR, and replaced it on an existing site with the v4.0.0-beta-1 (in order to be able to upgrade Umbraco to 13.7.1). Seems to work ok!

Was it just a straight forward build using Release config on that branch and reference DLLS in the website? I tried that but for some reason the extension methods I use in beta 1 aren't found.

[skttl]

I packed it as a nuget package using a command like

        dotnet pack Examine.sln --configuration Release --no-restore -p:PackageVersion=4.1.0-PullRequest0406 -p:AssemblyVersion=4.1.0 -p:FileVersion=4.1.0 -p:InformationalVersion=4.1.0 -p:ContinuousIntegrationBuild=true -p:Copyright="Examine" --output=./_NugetOutput

(don't remeber the exact one, you might have to fiddle with it).

I then copied the resulting .nupkg file into a folder in my project, and added that folder as a local nuget repository in a NuGet.config file

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
    <add key="local" value="./LocalPackages"></add>
  </packageSources>

  <activePackageSource>
    <add key="All" value="(Aggregate source)" />
  </activePackageSource>
  
</configuration>

And then installed the package.

If you trust me, you can simply download the nupkg files from here

Examine.zip

[dillorscroft]

I packed it as a nuget package using a command like

        dotnet pack Examine.sln --configuration Release --no-restore -p:PackageVersion=4.1.0-PullRequest0406 -p:AssemblyVersion=4.1.0 -p:FileVersion=4.1.0 -p:InformationalVersion=4.1.0 -p:ContinuousIntegrationBuild=true -p:Copyright="Examine" --output=./_NugetOutput

(don't remeber the exact one, you might have to fiddle with it).

I then copied the resulting .nupkg file into a folder in my project, and added that folder as a local nuget repository in a NuGet.config file

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
    <add key="local" value="./LocalPackages"></add>
  </packageSources>

  <activePackageSource>
    <add key="All" value="(Aggregate source)" />
  </activePackageSource>
  
</configuration>

And then installed the package.

If you trust me, you can simply download the nupkg files from here

Examine.zip

Thanks for that. Really appreciated.

[Shazwazza]

I'm just getting this PR merge going #403 and then I'll circle back to this

[brannmark]

Any status of this? Slipping behind with a couple of sites that Umbraco cant be upgraded on...

[Shazwazza]

@brannmark yes been working hard on getting things working. There was quite a large number of issues with the current beta - just FYI. As I've been going through and re-merging v3 to v4 with all latest fixes and changes, I've found quite a lot of issues that needed changing/fixing.

v4 will have breaking changes. Facets will be a first class citizen and currently all the hacks to handle compatibility have been removed. Once all the builds are working, then we can look to add a compatibility shim to have it work with certain Umbraco versions.

See https://github.com/Shazwazza/Examine/pull/416/files

[brannmark]

@Shazwazza Excellent. Thanks for all work. Any timeframe when a new nuget release will be availiable of theversion 4?