Skip to content

V4.0 Lucene 4.8.0-beta00017 breaking changes #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/4.0
Choose a base branch
from
Open

V4.0 Lucene 4.8.0-beta00017 breaking changes #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75fccb5
Updated Lucene package references to 4.8.0-beta00017
DevAndersen Mar 5, 2025
638d210
Updated code to use SnapshotDirectoryTaxonomyIndexWriterFactory
DevAndersen Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Examine.Lucene/Examine.Lucene.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Lucene.Net.QueryParser">
<Version>4.8.0-beta00016</Version>
<Version>4.8.0-beta00017</Version>
</PackageReference>
<PackageReference Include="Lucene.Net.Replicator" Version="4.8.0-beta00016" />
<PackageReference Include="Lucene.Net.Replicator" Version="4.8.0-beta00017" />
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
15 changes: 13 additions & 2 deletions src/Examine.Lucene/ExamineTaxonomyReplicator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ public void ReplicateIndex()
IndexAndTaxonomyRevision rev;
try
{
rev = new IndexAndTaxonomyRevision(_sourceIndex.IndexWriter.IndexWriter, _sourceIndex.TaxonomyWriter as SnapshotDirectoryTaxonomyWriter);
var factory = new SnapshotDirectoryTaxonomyIndexWriterFactory();
var indexWriter = factory.OpenIndexWriter(
_destinationDirectory,
factory.CreateIndexWriterConfig(OpenMode.CREATE_OR_APPEND));

rev = new IndexAndTaxonomyRevision(indexWriter, factory);
}
catch (InvalidOperationException)
{
Expand Down Expand Up @@ -159,7 +164,13 @@ private void SourceIndex_IndexCommitted(object? sender, EventArgs? e)
_logger.LogDebug("{IndexName} committed", index.Name);
}
}
var rev = new IndexAndTaxonomyRevision(_sourceIndex.IndexWriter.IndexWriter, _sourceIndex.TaxonomyWriter as SnapshotDirectoryTaxonomyWriter);

var factory = new SnapshotDirectoryTaxonomyIndexWriterFactory();
var indexWriter = factory.OpenIndexWriter(
_sourceIndex.GetLuceneDirectory(),
factory.CreateIndexWriterConfig(OpenMode.CREATE_OR_APPEND));

var rev = new IndexAndTaxonomyRevision(indexWriter, factory);
_replicator.Publish(rev);
}

Expand Down
5 changes: 3 additions & 2 deletions src/Examine.Lucene/Providers/LuceneIndex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using Lucene.Net.Facet.Taxonomy;
using Lucene.Net.Facet.Taxonomy.Directory;
using static Lucene.Net.Replicator.IndexAndTaxonomyRevision;
using Lucene.Net.Replicator;

namespace Examine.Lucene.Providers
{
Expand Down Expand Up @@ -1285,9 +1286,9 @@ protected virtual DirectoryTaxonomyWriter CreateTaxonomyWriter(Directory? d)
{
throw new ArgumentNullException(nameof(d));
}
var taxonomyWriter = new SnapshotDirectoryTaxonomyWriter(d);

return taxonomyWriter;
var factory = new SnapshotDirectoryTaxonomyIndexWriterFactory();
return new DirectoryTaxonomyWriter(factory, d);
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Examine.Test/Examine.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<ItemGroup>
<PackageReference Include="Azure.Storage.Blobs" Version="12.15.1" />
<PackageReference Include="Lucene.Net.Spatial">
<Version>4.8.0-beta00016</Version>
<Version>4.8.0-beta00017</Version>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.1" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
Expand Down