Drop anyhow #52
Merged
Drop anyhow #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't bring a ton of value for our use case, and adds ~50kb to the binary size.
jbourassa
commented
Feb 29, 2024
| @@ -1,4 +1,5 @@ | |||
| [workspace] | |||
| resolver = "2" | |||
There was a problem hiding this comment.
I threw that in to silence a warning.
jbourassa
commented
Feb 29, 2024
Comment on lines
+10
to
+11
| serde = { version = "1.0.197", features = ["derive"] } | ||
| serde_json = "1.0.114" |
There was a problem hiding this comment.
Why not bump those, while we're at it. I think more recent versions actually produce smaller binaries.
adampetro
approved these changes
Feb 29, 2024
|
@adampetro @jbourassa when it will be released as a new version? size of simple function is almost 300KB, and allowed one is ~260 |
|
Yes, hopefully today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't bring a ton of value for our use case, and adds ~50kb to the binary size.