Skip to content

Drop anyhow #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024
+46 −43
Merged

Drop anyhow #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 42 additions & 38 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[workspace]
resolver = "2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I threw that in to silence a warning.

members = [
"example",
"example_with_targets",
Expand Down
5 changes: 2 additions & 3 deletions shopify_function/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ license = "MIT"
description = "Crate to write Shopify Functions in Rust."

[dependencies]
serde = { version = "1.0.13", features = ["derive"] }
serde_json = "1.0"
anyhow = "1.0.62"
serde = { version = "1.0.197", features = ["derive"] }
serde_json = "1.0.114"
Comment on lines +10 to +11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump those, while we're at it. I think more recent versions actually produce smaller binaries.

shopify_function_macro = { version = "0.5.0", path = "../shopify_function_macro" }

[dev-dependencies]
Expand Down
3 changes: 1 addition & 2 deletions shopify_function/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ pub mod prelude {
pub use shopify_function_macro::{generate_types, shopify_function, shopify_function_target};
}

/// Convenience alias for `anyhow::Result`.
pub type Result<T> = anyhow::Result<T>;
pub type Result<T> = std::result::Result<T, Box<dyn std::error::Error>>;

/// Runs the given function `f` with the invocation payload, returning the
/// deserialized output. This function is provided as a helper when writing
Expand Down