Actually log progress updates #352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaned up version of #326 which does the same thing, but removes some unintended noise of related changes.
The change here is to properly populate log messages for progress statements. This has the potential to be very expensive, and we may quickly return here to put this under a separate logger (the main risk: there is no data reduction going on, so we are logging something proportional to the volume of progress messages rather than a summary of how much work we are doing). In addition, timestamps are converted to strings from their native types (which are often non-allocating) which could be another source of overhead.
This is potentially mitigated by the recent change to default progress tracking, to the
demand
variant that reduces the risk of runaway volumes of progress information.In principle, this and #321 could log into a different logger that could be enabled or disabled as appropriate. I think no one was using these messages, as they weren't properly populated, so while it would be technically breaking to do that, I don't think the fix would be more than changing enums around to not reference this variant.