Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at replicating #321 with some firm isolation between existing logging machinery and any new logging machinery. It has some opinions about where and how frequently we should log things (in batch, after consolidation), and it uses the abstraction of #352 to allow timestamps to be recovered via
dyn Any
downcasting.cc @utaal for any thoughts, but I should be able to move this forward even without any particular comments. I think if I extend it to capture the topology as well as the events it pretty closely resembles the intent of #321.