Remove Hash from Timestamp
#713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
commented
Sep 17, 2025
| /// By implementing this trait, you promise that the type's [PartialOrder] implementation | ||
| /// is compatible with [Ord], such that if `a.less_equal(b)` then `a <= b`. | ||
| pub trait Timestamp: Clone+Eq+PartialOrder+Debug+Send+Any+ExchangeData+Hash+Ord { | ||
| pub trait Timestamp: Clone+Eq+PartialOrder+Ord+Debug+Any+ExchangeData { |
There was a problem hiding this comment.
Moved Ord around, and removed Send because it is implied by ExchangeData.
frankmcsherry
commented
Sep 17, 2025
|
|
||
| /// A summary of how a timestamp advances along a timely dataflow path. | ||
| pub trait PathSummary<T> : Clone+'static+Eq+PartialOrder+Debug+Default { | ||
| pub trait PathSummary<T> : Clone+Eq+PartialOrder+Debug+Default { |
There was a problem hiding this comment.
The 'static bound seems unneeded and isn't present in Timestamp, so trying out the removal.
antiguru
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Hashtrait on timestamps was not used other than 1. to derive aHashimplementation forCapability<T>and 2. in support for various timestamp-indexed demo operators (delay, aggregate, etc). The bound is removed from the trait, and added to the implementations.Part of an effort to minimize the per-record reasoning. Timestamps are an instance, not the main instance, but .. this came up.