-
Notifications
You must be signed in to change notification settings - Fork 288
Remove Hash
from Timestamp
#713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frankmcsherry
merged 1 commit into
TimelyDataflow:master
from
frankmcsherry:timestamp_trait_tidy
Sep 17, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ | |
use std::fmt::Debug; | ||
use std::any::Any; | ||
use std::default::Default; | ||
use std::hash::Hash; | ||
|
||
use crate::ExchangeData; | ||
use crate::order::PartialOrder; | ||
|
@@ -12,7 +11,7 @@ use crate::order::PartialOrder; | |
/// | ||
/// By implementing this trait, you promise that the type's [PartialOrder] implementation | ||
/// is compatible with [Ord], such that if `a.less_equal(b)` then `a <= b`. | ||
pub trait Timestamp: Clone+Eq+PartialOrder+Debug+Send+Any+ExchangeData+Hash+Ord { | ||
pub trait Timestamp: Clone+Eq+PartialOrder+Ord+Debug+Any+ExchangeData { | ||
/// A type summarizing action on a timestamp along a dataflow path. | ||
type Summary : PathSummary<Self> + 'static; | ||
/// A unique minimum value in our partial order. | ||
|
@@ -22,7 +21,7 @@ pub trait Timestamp: Clone+Eq+PartialOrder+Debug+Send+Any+ExchangeData+Hash+Ord | |
} | ||
|
||
/// A summary of how a timestamp advances along a timely dataflow path. | ||
pub trait PathSummary<T> : Clone+'static+Eq+PartialOrder+Debug+Default { | ||
pub trait PathSummary<T> : Clone+Eq+PartialOrder+Debug+Default { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
/// Advances a timestamp according to the timestamp actions on the path. | ||
/// | ||
/// The path may advance the timestamp sufficiently that it is no longer valid, for example if | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved
Ord
around, and removedSend
because it is implied byExchangeData
.