Skip to content

Conversation

@matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Sep 25, 2024

Closes #1101

@vercel
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Sep 29, 2024 7:26pm
blocknote-website ✅ Ready (Inspect) Visit Preview Sep 29, 2024 7:26pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! However, as it's pretty core functionality, I think we should add more unit tests for all the different scenarios before merging this

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@YousefED YousefED merged commit ecddc65 into main Oct 8, 2024
2 of 3 checks passed
@nperez0111 nperez0111 deleted the block-content-update-fix branch October 21, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using editor.updateBlock while changing the content of the block deletes the children

2 participants