build: enable kvbm in trtllm container

[nv-anants]

closes: OPS-850

Summary by CodeRabbit

• Improvements

  • Ensured KVBM is automatically enabled for both VLLM and TRTLLM image builds, aligning behavior across frameworks and potentially improving performance consistency.

• Tests

  • Broadened a determinism test to run beyond vLLM-specific scope.
  • Temporarily skipped a flaky concurrent determinism test to stabilize test runs.

[coderabbitai]

Walkthrough

The build script now enables KVBM when FRAMEWORK is either "VLLM" or "TRTLLM" in both relevant condition blocks. Tests adjusted: one vLLM-specific marker removed to broaden scope; one flaky test is skipped with a reason tag.

Changes

Cohort / File(s)	Summary
Build enablement logic container/build.sh	Expanded conditional to set ENABLE_KVBM when FRAMEWORK == "VLLM" or "TRTLLM" (applied in both occurrences).
KVBM determinism tests tests/kvbm/test_determinism.py	Removed @pytest.mark.vllm from test_determinism_with_cache_reset; added @pytest.mark.skip(reason="Flaky test: DIS-665") to test_concurrent_determinism_with_ifeval.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Invoker
  participant Build as container/build.sh
  participant Env as ENV Vars
  participant Img as Docker Build

  Dev->>Build: Run build with FRAMEWORK
  Build->>Env: Read FRAMEWORK
  alt FRAMEWORK in {"VLLM","TRTLLM"}
    Build->>Env: Set ENABLE_KVBM=true
    note over Build,Env: KVBM forced on for VLLM/TRTLLM
  else Other frameworks
    Build->>Env: Leave ENABLE_KVBM as configured
  end
  Build->>Img: Proceed with image build
  Img-->>Dev: Image artifact

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• build: enable kvbm in vllm container #2763 — Earlier change to force ENABLE_KVBM for VLLM builds in container/build.sh; this PR extends to TRTLLM.
• fix: Update the KVBM <> TRT-LLM integration interface to match the latest TRT-LLM connector API #2979 — Adds/adjusts KVBM handling in TRT-LLM build flow; complements enabling KVBM for TRTLLM here.
• ci: sglang functional tests #2943 — Introduces TRTLLM to CI matrix, exercising the new ENABLE_KVBM-for-TRTLLM path.

Poem

A bunny flips a build-time switch,
KVBM now hops without a hitch.
VLLM, TRTLLM—both in tow,
Determinism tests come and go.
One flaky carrot set aside,
The pipeline hums—a smoother ride. 🥕🚀

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description only contains "closes: OPS-850" and does not follow the repository template; required sections such as Overview, Details, and Where should the reviewer start? are missing or left as placeholders, so reviewers lack context, rationale, and testing instructions.	Update the PR description to follow the template by adding a concise Overview, a Details section that enumerates the file-level changes (notably container/build.sh and tests/kvbm/test_determinism.py), a "Where should the reviewer start?" pointer to key files, a brief test plan or verification steps, and confirm the related issue reference (OPS-850) in the Related Issues section.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title Check	✅ Passed	The title "build: enable kvbm in trtllm container" is concise and accurately summarizes the primary change — enabling KVBM for the TRTLLM build/container — and directly matches the modifications to container/build.sh described in the changeset.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tests/kvbm/test_determinism.py (1)

918-927: Prefer xfail over skip to keep signal

Mark flaky as xfail so it still runs and reports.

-    @pytest.mark.skip(reason="Flaky test: DIS-665")
+    @pytest.mark.xfail(reason="Flaky test: DIS-665", strict=False)
     def test_concurrent_determinism_with_ifeval(

container/build.sh (1)

696-699: Fix misleading log; Dockerfile.trtllm consumes ENABLE_KVBM

• Update the echo to reference the actual $FRAMEWORK being built.
• Dockerfile.trtllm declares ARG ENABLE_KVBM=false, so TRTLLM will receive the build arg.

-if [[ $FRAMEWORK == "VLLM" ]] || [[ $FRAMEWORK == "TRTLLM" ]]; then
-    echo "Forcing enable_kvbm to true in vLLM image build"
+if [[ $FRAMEWORK == "VLLM" ]] || [[ $FRAMEWORK == "TRTLLM" ]]; then
+    echo "Forcing ENABLE_KVBM=true for ${FRAMEWORK} image build"
     ENABLE_KVBM=true
 fi

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c433447 and 2613060.

📒 Files selected for processing (2)

• container/build.sh (1 hunks)
• tests/kvbm/test_determinism.py (1 hunks)