Skip to content

build: enable kvbm in trtllm container #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 24, 2025
Merged

build: enable kvbm in trtllm container #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2b5e10a
build: enable kvbm in trtllm container
nv-anants Sep 9, 2025
1333cab
Merge branch 'main' into anants/kvbm-trtllm
nv-anants Sep 9, 2025
716d177
add kvbm flag
nv-anants Sep 9, 2025
59efc41
add maturin
nv-anants Sep 10, 2025
3437410
Merge branch 'main' into anants/kvbm-trtllm
nv-anants Sep 10, 2025
d54a6b5
Merge branch 'main' into anants/kvbm-trtllm
nv-anants Sep 17, 2025
82bbf1a
Merge branch 'main' into anants/kvbm-trtllm
nv-anants Sep 18, 2025
51a2cc5
remove
nv-anants Sep 23, 2025
7cc2157
Merge branch 'main' into anants/kvbm-trtllm
nv-anants Sep 23, 2025
2613060
update test markers
nv-anants Sep 23, 2025
3cc6bdf
fix message
nv-anants Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions container/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,8 +693,8 @@ if [ ! -z ${RELEASE_BUILD} ]; then
BUILD_ARGS+=" --build-arg RELEASE_BUILD=${RELEASE_BUILD} "
fi

if [[ $FRAMEWORK == "VLLM" ]]; then
echo "Forcing enable_kvbm to true in vLLM image build"
if [[ $FRAMEWORK == "VLLM" ]] || [[ $FRAMEWORK == "TRTLLM" ]]; then
echo "Forcing enable_kvbm to true in ${FRAMEWORK} image build"
ENABLE_KVBM=true
fi

Expand Down
2 changes: 1 addition & 1 deletion tests/kvbm/test_determinism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,6 @@ class TestDeterminism:
],
indirect=True,
)
@pytest.mark.vllm
def test_determinism_with_cache_reset(self, tester, llm_server, runtime_services):
"""Test determinism across cache reset: run test with warmup, reset cache, run again without warmup."""
print("\n" + "=" * 70)
Expand Down Expand Up @@ -916,6 +915,7 @@ def test_determinism_with_cache_reset(self, tester, llm_server, runtime_services
"num_prompts",
[int(x) for x in os.environ.get("KVBM_IFEVAL_PROMPTS", "120").split(",")],
)
@pytest.mark.skip(reason="Flaky test: DIS-665")
def test_concurrent_determinism_with_ifeval(
self,
tester,
Expand Down
Loading