Upgrade to Yarn v3, Nx 13.1.4, and move to @nrwl/nx-plugin proper structure #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpsnyder
force-pushed
the
task/upgrade-to-yarn-v3
branch
from
09e2e97 to
88c4ab4
Compare
benpsnyder
changed the title
|
@manfredsteyer @peterbsmyth this is ready to go. |
PetarKirov
reviewed
Dec 7, 2021
package.json
Outdated
| "test": "nx test", | ||
| "lint": "nx workspace-lint && nx lint", | ||
| "e2e": "nx e2e", | ||
| "affected": "nx affected", |
There was a problem hiding this comment.
The changes to package.json in this commit would be easier to review if you include a commit that sorts the scripts entries by key name. Essentially you can apply the lint rules like this https://ota-meshi.github.io/eslint-plugin-jsonc/rules/sort-keys.html in a separate commit.
|
@benpsnyder @PetarKirov this PR is important. when it will merge and release? |
|
@manfredsteyer I would be willing to maintain and release consistently if you authorize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were issues with running normal CLI upgrade commands, so I had to use the following:
npx @nrwl/tao@latest migrate @nrwl/[email protected] @nrwl/[email protected] --from="@nrwl/[email protected]"Upgrading to Yarn v3 based on lessons learned from:
Reorganized files based on:
npx create-nx-plugin @angular-architects --pluginName ddd