Skip to content

Switch to Yarn v3 as the package manager default #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

benpsnyder
Copy link
Contributor

Yarn v3 has some nice innovations. I am proposing to use Yarn over NPM as the default for this repository and am sending this PR as an example of what we have implemented as a standard at our company. We perform yarn set version berry then yarn set version 3.x because there is a bug in the stable version.

@srleecode
Copy link
Owner

Related issues in nx which look like they should be fixed before this one can be merged: nrwl/nx#7504 and nrwl/nx#7918.

With the other changes in the recent 13.2.3 release, I couldn't figure out the spawnSync issue and related issues that occur when running the e2e tasks using affected. For now, I will be running all of the e2e jobs in sequence and not using affected for the e2e test runs.

When running the E2E with this branch, I was getting errors on the package manager install saying that the yarn command failed.

@nx-cloud
Copy link

nx-cloud bot commented Nov 28, 2021

Nx Cloud Report

CI is running for commit 62b67df.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

@benpsnyder
Copy link
Contributor Author

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

@benpsnyder benpsnyder reopened this Nov 28, 2021
@srleecode
Copy link
Owner

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.

/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty
Command failed: touch yarn.lock && yarn

@benpsnyder
Copy link
Contributor Author

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.

/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty Command failed: touch yarn.lock && yarn

try now... I an using yarn dlx now and touch from node

@srleecode
Copy link
Owner

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.
/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty Command failed: touch yarn.lock && yarn

try now... I an using yarn dlx now and touch from node

Locally it is working. However, on the CI job it failed: https://github.com/srleecode/domain/runs/4353924313?check_suite_focus=true

Command failed: node /home/runner/work/domain/domain/node_modules/@nrwl/tao/index.js new proj --nx-workspace-root=/home/runner/work/domain/domain/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty 
Command failed: yarn dlx touch yarn.lock && yarn

@srleecode
Copy link
Owner

closing as nrwl/nx#7918 was closed

@srleecode srleecode closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants