-
Notifications
You must be signed in to change notification settings - Fork 5
Switch to Yarn v3 as the package manager default #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
benpsnyder
wants to merge
18
commits into
srleecode:master
from
snydertechnologies:task/move-to-yarn-v3
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8293a02
chore: upgrade to Nx 13.3.0-beta.3
benpsnyder 96582fb
chore: update to nx-cloud v13
benpsnyder 23edf5d
chore: add patches until Nx core is fixed
benpsnyder 005343d
chore: remove package-lock.json files
benpsnyder 4d4b964
chore: minor package increments
benpsnyder 2577b54
feat: add @yarnpkg/plugin-dlx dev dependency
benpsnyder ca03d45
fix: use yarn `dlx` for cross-platform touch
benpsnyder 228b16f
chore: switch to yarn dlx over npx
benpsnyder f904b17
chore: update package.json
benpsnyder 6cb9e52
Merge branch 'master' into task/move-to-yarn-v3
benpsnyder 60ed188
chore: switch to yarn dlx over npx
benpsnyder 20d2f2a
fix: ci needs to respect forked PRs
benpsnyder 931893c
fix: change to use 'parallel=N'
benpsnyder ece3cd8
fix(core): revert 'yarn run nx-cloud'
benpsnyder e50a188
feat: upgrade Nx beta version
benpsnyder 9b39be6
fix: nx cloud version
benpsnyder 03f14ec
fix: update patches for tao and nx-plugin
benpsnyder 62b67df
fix: update patches
benpsnyder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
npx --no-install commitlint --edit $1 | ||
yarn dlx commitlint --edit $1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
.yarn/patches/@nrwl-nx-plugin-npm-13.3.0-beta.13-8b8229d6d1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/src/utils/testing-utils/nx-project.js b/src/utils/testing-utils/nx-project.js | ||
index 7284da90de99a43453af342e2686273b66132738..59f3657afa59d06fdf0b9129f1b5a5e5fff5b206 100644 | ||
--- a/src/utils/testing-utils/nx-project.js | ||
+++ b/src/utils/testing-utils/nx-project.js | ||
@@ -10,7 +10,7 @@ const paths_1 = require("./paths"); | ||
const utils_1 = require("./utils"); | ||
function runNxNewCommand(args, silent) { | ||
const localTmpDir = (0, path_1.dirname)((0, paths_1.tmpProjPath)()); | ||
- return (0, child_process_1.execSync)(`node ${require.resolve('@nrwl/tao')} new proj --nx-workspace-root=${localTmpDir} --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --preset=empty ${args || ''}`, Object.assign({ cwd: localTmpDir }, (silent && false ? { stdio: ['ignore', 'ignore', 'ignore'] } : {}))); | ||
+ return (0, child_process_1.execSync)(`node ${require.resolve('@nrwl/tao')} new proj --nx-workspace-root=${localTmpDir} --packageManager=yarn --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --preset=empty ${args || ''}`, Object.assign({ cwd: localTmpDir }, (silent && false ? { stdio: ['ignore', 'ignore', 'ignore'] } : {}))); | ||
} | ||
function patchPackageJsonForPlugin(npmPackageName, distPath) { | ||
const path = (0, paths_1.tmpProjPath)('package.json'); |
13 changes: 13 additions & 0 deletions
13
.yarn/patches/@nrwl-nx-plugin-npm-13.3.0-beta.3-f28720d9c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/src/utils/testing-utils/nx-project.js b/src/utils/testing-utils/nx-project.js | ||
index 7284da90de99a43453af342e2686273b66132738..e2974e7158ed8ab5359312dd252af004fff25cf6 100644 | ||
--- a/src/utils/testing-utils/nx-project.js | ||
+++ b/src/utils/testing-utils/nx-project.js | ||
@@ -10,7 +10,7 @@ const paths_1 = require("./paths"); | ||
const utils_1 = require("./utils"); | ||
function runNxNewCommand(args, silent) { | ||
const localTmpDir = (0, path_1.dirname)((0, paths_1.tmpProjPath)()); | ||
- return (0, child_process_1.execSync)(`node ${require.resolve('@nrwl/tao')} new proj --nx-workspace-root=${localTmpDir} --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --preset=empty ${args || ''}`, Object.assign({ cwd: localTmpDir }, (silent && false ? { stdio: ['ignore', 'ignore', 'ignore'] } : {}))); | ||
+ return (0, child_process_1.execSync)(`node ${require.resolve('@nrwl/tao')} new proj --nx-workspace-root=${localTmpDir} --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty ${args || ''}`, Object.assign({ cwd: localTmpDir }, (silent && false ? { stdio: ['ignore', 'ignore', 'ignore'] } : {}))); | ||
} | ||
function patchPackageJsonForPlugin(npmPackageName, distPath) { | ||
const path = (0, paths_1.tmpProjPath)('package.json'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/src/shared/package-manager.js b/src/shared/package-manager.js | ||
index 259ff28b90bea84abd71e53d410798d9e71ba1db..f7f99cb848d81cc5f3cc19ae748501247deb67df 100644 | ||
--- a/src/shared/package-manager.js | ||
+++ b/src/shared/package-manager.js | ||
@@ -29,7 +29,7 @@ exports.detectPackageManager = detectPackageManager; | ||
function getPackageManagerCommand(packageManager = detectPackageManager()) { | ||
const commands = { | ||
yarn: () => ({ | ||
- install: 'yarn', | ||
+ install: 'yarn dlx touch yarn.lock && yarn', | ||
add: 'yarn add', | ||
addDev: 'yarn add -D', | ||
rm: 'yarn remove', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/src/shared/package-manager.js b/src/shared/package-manager.js | ||
index 259ff28b90bea84abd71e53d410798d9e71ba1db..bc7136f9ab264df9daa6de110cfb90a4f9c2d5f1 100644 | ||
--- a/src/shared/package-manager.js | ||
+++ b/src/shared/package-manager.js | ||
@@ -29,7 +29,7 @@ exports.detectPackageManager = detectPackageManager; | ||
function getPackageManagerCommand(packageManager = detectPackageManager()) { | ||
const commands = { | ||
yarn: () => ({ | ||
- install: 'yarn', | ||
+ install: 'yarn dlx touch yarn.lock && yarn', | ||
add: 'yarn add', | ||
addDev: 'yarn add -D', | ||
rm: 'yarn remove', |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
nodeLinker: node-modules | ||
|
||
plugins: | ||
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||
spec: '@yarnpkg/plugin-interactive-tools' | ||
|
||
yarnPath: .yarn/releases/yarn-3.2.0-rc.6.cjs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.