Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Mar 12, 2025

Description

  • Added the ability to set a component name via setter (ie. component.name = "name")
  • Tested on design and component objects

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Mar 12, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 12, 2025 14:54
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) March 12, 2025 14:55
@jonahrb
Copy link
Contributor

jonahrb commented Mar 12, 2025

@jacobrkerstetter should this call rename_object() so that the client and server names are matching?

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 12, 2025
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (ce21ad6) to head (ce73403).
Report is 1 commits behind head on blitz.

❌ Your project status has failed because the head coverage (88.75%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1820      +/-   ##
==========================================
+ Coverage   88.74%   88.75%   +0.01%     
==========================================
  Files          92       92              
  Lines        8593     8603      +10     
==========================================
+ Hits         7626     7636      +10     
  Misses        967      967              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - thanks @jacobrkerstetter!

@RobPasMue
Copy link
Member

You might need to bump the API package version too, right? 0.4.47 if I am not mistaken

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 12, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) March 13, 2025 12:15
@RobPasMue RobPasMue disabled auto-merge March 13, 2025 13:24
@RobPasMue RobPasMue merged commit c7ec5d8 into blitz Mar 13, 2025
25 of 27 checks passed
@RobPasMue RobPasMue deleted the feat/object_name_setters branch March 13, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants