Skip to content

Conversation

@ustcweizhou
Copy link
Contributor

Description

libvirt-bin does not exist any more in Ubuntu 20.04, restart libvirtd instead of libvirt-bin after configuration when add a host.

in summary:
ubuntu 16.04: libvirt-bin
ubuntu 18.04: libvirt-bin and libvirtd (they are same)
ubuntu 20.04: libvirtd

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@rohityadavcloud rohityadavcloud added this to the 4.15.0.0 milestone Sep 1, 2020
@rohityadavcloud
Copy link
Member

Changes LGTM
@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-1867

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blueorangutan
Copy link

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1875

@Pearl1594
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-1877

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1878

@rohityadavcloud
Copy link
Member

Manually kicked smoketests against Ubuntu 18.04 (mgmt server + kvm host)

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rohityadavcloud rohityadavcloud merged commit f38db8a into apache:master Sep 4, 2020
@rohityadavcloud
Copy link
Member

Verified manually lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants