-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding button to toggle fullscreen in noVNC console #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
9a155a7 to
54ffd17
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1927 |
54ffd17 to
8a1fafe
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@davidjumani if it's not too much work could this be provided as a toolbar option like upstream novnc does (let user decide if the console needs to be scaled down or not)? |
|
@rhtyd Right not using the vnc_lite.html not the vnc.html to prevent users from unknowingly changing settings which could break stuff. Can look into creating a fullscreen button |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1928 |
8a1fafe to
2e2f2d5
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1931 |
|
@rhtyd Added a button on the noVNC page to toggle fullscreen mode! |
|
Closing in favour of #4323 |

Description
Adding button to toggle fullscreen in the noVNC console UI
Types of changes
Screenshots (if appropriate):