Skip to content

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Sep 9, 2020

Description

Adding button to toggle fullscreen in the noVNC console UI

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Screenshot from 2020-09-09 19-06-02
Screenshot from 2020-09-09 19-06-10

@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1927

@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 4.15.0.0 milestone Sep 9, 2020
@rohityadavcloud
Copy link
Member

@davidjumani if it's not too much work could this be provided as a toolbar option like upstream novnc does (let user decide if the console needs to be scaled down or not)?

Screenshot from 2020-09-09 15-53-57

@davidjumani
Copy link
Contributor Author

@rhtyd Right not using the vnc_lite.html not the vnc.html to prevent users from unknowingly changing settings which could break stuff. Can look into creating a fullscreen button

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1928

@davidjumani davidjumani changed the title Adding global setting to scale noVNC console display Adding button to toggle fullscreen in noVNC console Sep 9, 2020
@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1931

@davidjumani
Copy link
Contributor Author

@rhtyd Added a button on the noVNC page to toggle fullscreen mode!

@davidjumani
Copy link
Contributor Author

Closing in favour of #4323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants