Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Apr 17, 2024

Which issue does this PR close?

Closes #10119

Rationale for this change

Avoid intermittent failures in CI tests

What changes are included in this PR?

Add a rowsort to a non deterministic query added in #10095 by @mustafasrepo

Are these changes tested?

Yes

Are there any user-facing changes?

No, this is a test only change

@alamb alamb marked this pull request as ready for review April 17, 2024 17:08
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 17, 2024
@alamb alamb merged commit 0b67078 into apache:main Apr 17, 2024
@alamb
Copy link
Contributor Author

alamb commented Apr 17, 2024

Thank you for the (very) quick review @viirya

@alamb alamb deleted the alamb/intermittent_failure branch April 17, 2024 17:51
@viirya
Copy link
Member

viirya commented Apr 17, 2024

Thank you for fixing the CI! @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent CI failure on at test_files/joins.slt:3676

2 participants