feat: Finalize support for RightMark join + Mark join swap
#16488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jonathanc-n
changed the title
RightMark joinRightMark join + Mark join swap
|
If you have the time, are you able to take a look? Should be a straightforward review, thanks! @comphead @Dandandan |
Thanks @jonathanc-n its on my list! |
comphead
reviewed
Jun 27, 2025
| 02)--FilterExec: t1_id@0 > 40 OR NOT mark@3, projection=[t1_id@0, t1_name@1, t1_int@2] | ||
| 03)----CoalesceBatchesExec: target_batch_size=2 | ||
| 04)------HashJoinExec: mode=CollectLeft, join_type=LeftMark, on=[(t1_id@0, t2_id@0)] | ||
| 04)------HashJoinExec: mode=CollectLeft, join_type=RightMark, on=[(t2_id@0, t1_id@0)] |
There was a problem hiding this comment.
why this suddenly changed?
There was a problem hiding this comment.
Swapping is now supported, so it was optimized to swap in the physical plan based on the table sizes
comphead
approved these changes
Jun 27, 2025
|
The extended tests started failing after this PR was merged: |
comphead
added a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jun 27, 2025
apache#16488)" This reverts commit d73f0e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We need to support Sort Merge Join, Symmetric Hash Join and swapping join sides for Mark Joins.
What changes are included in this PR?
Support SMJ + SHJ
SortMergeJoinandSymmetricHashJoinAdded Support for Swap
Are these changes tested?
Yes added unit tests, and sqllogictests shows that swapping support works