-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Revert Finalize support for RightMark
join + Mark
join
#16597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apache#16488)" This reverts commit d73f0e8.
RightMark
join + Mark
join swa…RightMark
join + Mark
join
FYI @jonathanc-n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @comphead -- I think it is a good idea to back this out and fix it for real when we are ready
we should probably ask to run extended tests if PR label is one of |
Yeah, I think we never figured out how to actually trigger it via comments (there is some vestigal github action but i don't htink it works reliably) |
I'm not sure if you can access it https://github.com/apache/datafusion/actions/workflows/extended.yml |
I think you can just put a comment like this in your PR Run extended tests If not, you can also run it manually https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite |
…p (#16488)"
This reverts commit d73f0e8.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?