bug: Support null as argument to to_local_time #17491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
petern48
commented
Sep 9, 2025
Comment on lines
362
to
364
| match time_value { | ||
| Timestamp(timeunit, _) => Ok(Timestamp(*timeunit, None)), | ||
| DataType::Null => Ok(Timestamp(Nanosecond, None)), |
Contributor
Author
There was a problem hiding this comment.
I'm following the same behavior as date_trunc.rs here: returning a Nanosecond Timestamp datatype for nulls.
datafusion/datafusion/functions/src/datetime/date_trunc.rs
Lines 150 to 154 in fc5888b
Contributor
|
FYI @2010YOUY01 |
findepi
approved these changes
Sep 10, 2025
because to_local_time impls coerce_types, the Null argument gets coerced
findepi
approved these changes
Sep 11, 2025
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
to_local_time()function (SQLancer) #17472Rationale for this change
See issue.
What changes are included in this PR?
Add support for null argument to to_local_time function
Are these changes tested?
Added both scalar and array tests
Are there any user-facing changes?
Yes