Skip to content

bug: Support null as argument to to_local_time #17491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2025
Merged

bug: Support null as argument to to_local_time #17491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b71c7ff
Support null argument for to_local_time
petern48 Sep 9, 2025
5da67ee
Add scalar null test
petern48 Sep 9, 2025
f4063c4
Add array null tests
petern48 Sep 9, 2025
03d77b1
remove unreachable lines
findepi Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafusion/functions/src/datetime/to_local_time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ impl ScalarUDFImpl for ToLocalTimeFunc {

let first_arg = arg_types[0].clone();
match &first_arg {
DataType::Null => Ok(vec![Timestamp(Nanosecond, None)]),
Timestamp(Nanosecond, timezone) => {
Ok(vec![Timestamp(Nanosecond, timezone.clone())])
}
Expand Down
11 changes: 11 additions & 0 deletions datafusion/sqllogictest/test_files/timestamps.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3236,6 +3236,11 @@ select to_local_time('2024-04-01T00:00:20Z'::timestamp AT TIME ZONE 'Europe/Brus
----
2024-04-01T00:00:20

query P
select to_local_time(NULL);
----
NULL

query PTPT
select
time,
Expand Down Expand Up @@ -3263,6 +3268,7 @@ select date_bin(interval '1 day', to_local_time('2024-04-01T00:00:20Z'::timestam
statement ok
create table t AS
VALUES
(NULL),
('2024-01-01T00:00:01Z'),
('2024-02-01T00:00:01Z'),
('2024-03-01T00:00:01Z'),
Expand Down Expand Up @@ -3290,6 +3296,7 @@ from t;
query PPT
select column1, to_local_time(column1::timestamp), arrow_typeof(to_local_time(column1::timestamp)) from t_utc;
----
NULL NULL Timestamp(Nanosecond, None)
2024-01-01T00:00:01Z 2024-01-01T00:00:01 Timestamp(Nanosecond, None)
2024-02-01T00:00:01Z 2024-02-01T00:00:01 Timestamp(Nanosecond, None)
2024-03-01T00:00:01Z 2024-03-01T00:00:01 Timestamp(Nanosecond, None)
Expand All @@ -3306,6 +3313,7 @@ select column1, to_local_time(column1::timestamp), arrow_typeof(to_local_time(co
query PPT
select column1, to_local_time(column1), arrow_typeof(to_local_time(column1)) from t_utc;
----
NULL NULL Timestamp(Nanosecond, None)
2024-01-01T00:00:01Z 2024-01-01T00:00:01 Timestamp(Nanosecond, None)
2024-02-01T00:00:01Z 2024-02-01T00:00:01 Timestamp(Nanosecond, None)
2024-03-01T00:00:01Z 2024-03-01T00:00:01 Timestamp(Nanosecond, None)
Expand All @@ -3322,6 +3330,7 @@ select column1, to_local_time(column1), arrow_typeof(to_local_time(column1)) fro
query PPT
select column1, to_local_time(column1), arrow_typeof(to_local_time(column1)) from t_timezone;
----
NULL NULL Timestamp(Nanosecond, None)
2024-01-01T00:00:01+01:00 2024-01-01T00:00:01 Timestamp(Nanosecond, None)
2024-02-01T00:00:01+01:00 2024-02-01T00:00:01 Timestamp(Nanosecond, None)
2024-03-01T00:00:01+01:00 2024-03-01T00:00:01 Timestamp(Nanosecond, None)
Expand All @@ -3339,6 +3348,7 @@ select column1, to_local_time(column1), arrow_typeof(to_local_time(column1)) fro
query P
select date_bin(interval '1 day', to_local_time(column1)) AT TIME ZONE 'Europe/Brussels' as date_bin from t_utc;
----
NULL
2024-01-01T00:00:00+01:00
2024-02-01T00:00:00+01:00
2024-03-01T00:00:00+01:00
Expand All @@ -3355,6 +3365,7 @@ select date_bin(interval '1 day', to_local_time(column1)) AT TIME ZONE 'Europe/B
query P
select date_bin(interval '1 day', to_local_time(column1)) AT TIME ZONE 'Europe/Brussels' as date_bin from t_timezone;
----
NULL
2024-01-01T00:00:00+01:00
2024-02-01T00:00:00+01:00
2024-03-01T00:00:00+01:00
Expand Down