Increase test coverage for unbounded and bounded cases #8581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iour # Conflicts: # datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs
…ithub.com/synnada-ai/arrow-datafusion into minor/convert_tests_to_previous_behaviour # Conflicts: # datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs
ozankabak
approved these changes
Dec 19, 2023
|
Since this doesn't change any code except tests I will go ahead and merge it to let code flow. In case of any future issues related to this PR, we will quickly address with follow-ons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In the PR we parametrize tests to increase test coverage. This PR extends this PR so that tests consider unbounded, and bounded sources when
prefer_existing_sortflag isfalseandtrue.All of the changes are in tests. This PR effectively increases test coverage.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?