[CI] Use alias for table.struct #9894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
alamb
approved these changes
Apr 1, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211 -- sorry for messing this up.
See #9891 (comment)
I'll try and go do the follow on #9839
Contributor
|
Thank you @jayzhan211 |
Contributor
|
Merging this in to get CI clean again. |
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Apr 1, 2024
This reverts commit 9487ca0.
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
Signed-off-by: jayzhan211 <[email protected]>
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Apr 5, 2024
…che#9897) * Revert "use alias (apache#9894)" This reverts commit 9487ca0. * Use `struct` instead of `named_struct` when there are no aliases * Update docs * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
A workaround to fix Closes #9891 .
Replace the problematic struct literal with alias
We can support accessing table with explicit struct literal later on.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?