HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var #6969

kevincai · 2024-07-31T23:45:59Z

Description of PR

the jni state tls object is set before passing all the checks, resulting an invalid state in the tls and been hit later on with invalid object which already destroyed.

How was this patch tested?

set the tls object lastly when passing all checks. A sample binary is added to expose this issue and verify the fix.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-07-31T23:55:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	7m 27s		Docker failed to build run-specific yetus/hadoop:tp-16675}.

Subsystem	Report/Notes
GITHUB PR	#6969
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/1/console
versions	git=2.34.1
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

kevincai · 2024-08-01T00:04:22Z

saw the docker CI failed, am I doing something wrong?

zhengchenyu · 2024-08-02T10:45:34Z

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See #6973 for more information.

kevincai · 2024-08-02T17:08:12Z

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See #6973 for more information.

guess I should wait for your PR merged and then rebase mine?

tomscut · 2024-08-05T02:14:06Z

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See #6973 for more information.

guess I should wait for your PR merged and then rebase mine?

I merge the #6973.

hadoop-yetus · 2024-08-05T22:38:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	19m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 55s		trunk passed
+1 💚	compile	2m 4s		trunk passed
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	shadedclient	56m 0s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 10s		the patch passed
+1 💚	compile	1m 57s		the patch passed
+1 💚	cc	1m 57s		the patch passed
+1 💚	golang	1m 57s		the patch passed
+1 💚	javac	1m 57s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌	blanks	0m 0s	/blanks-tabs.txt	The patch 2 line(s) with tabs.
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shadedclient	19m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 34s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		105m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux a63e87ac4a88 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f6dc302`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T01:31:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 50s		trunk passed
+1 💚	compile	2m 1s		trunk passed
+1 💚	mvnsite	0m 22s		trunk passed
+1 💚	shadedclient	55m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s		the patch passed
+1 💚	compile	2m 1s		the patch passed
+1 💚	cc	2m 1s		the patch passed
+1 💚	golang	2m 1s		the patch passed
+1 💚	javac	2m 1s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shadedclient	19m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 36s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		85m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 540ebb8ab1a7 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e330ff4`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/testReport/
Max. process+thread count	673 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T03:34:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 57s		trunk passed
+1 💚	compile	2m 2s		trunk passed
+1 💚	mvnsite	0m 18s		trunk passed
+1 💚	shadedclient	55m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s		the patch passed
+1 💚	compile	1m 58s		the patch passed
+1 💚	cc	1m 58s		the patch passed
+1 💚	golang	1m 58s		the patch passed
+1 💚	javac	1m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 13s		the patch passed
+1 💚	shadedclient	19m 32s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 28s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		85m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux f18c479d6a09 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e7383eb`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/testReport/
Max. process+thread count	727 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T07:06:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 26s		trunk passed
+1 💚	compile	2m 3s		trunk passed
+1 💚	mvnsite	0m 22s		trunk passed
+1 💚	shadedclient	56m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s		the patch passed
+1 💚	compile	1m 56s		the patch passed
-1 ❌	cc	1m 56s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client.txt	hadoop-hdfs-project_hadoop-hdfs-native-client generated 4 new + 8 unchanged - 0 fixed = 12 total (was 8)
+1 💚	golang	1m 56s		the patch passed
+1 💚	javac	1m 56s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 15s		the patch passed
+1 💚	shadedclient	19m 34s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 31s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		86m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux ff053e1aa8d4 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a031775`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T18:20:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
-1 ❌	mvninstall	35m 24s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	2m 3s		trunk passed
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	shadedclient	57m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s		the patch passed
+1 💚	compile	1m 58s		the patch passed
+1 💚	cc	1m 58s		the patch passed
+1 💚	golang	1m 58s		the patch passed
+1 💚	javac	1m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 15s		the patch passed
+1 💚	shadedclient	19m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 28s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		86m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 1603251d2477 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b99bd3e`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T21:46:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 37s		trunk passed
+1 💚	compile	2m 4s		trunk passed
+1 💚	mvnsite	0m 19s		trunk passed
+1 💚	shadedclient	55m 28s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s		the patch passed
+1 💚	compile	1m 58s		the patch passed
+1 💚	cc	1m 58s		the patch passed
+1 💚	golang	1m 58s		the patch passed
+1 💚	javac	1m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shadedclient	19m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 36s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		85m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux cc46c6caff0a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cdc9ccb`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/
Max. process+thread count	557 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-06T23:06:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	17m 36s		trunk passed
+1 💚	compile	2m 13s		trunk passed
+1 💚	mvnsite	0m 31s		trunk passed
+1 💚	shadedclient	39m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	2m 3s		the patch passed
+1 💚	cc	2m 3s		the patch passed
+1 💚	golang	2m 3s		the patch passed
+1 💚	javac	2m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 19s		the patch passed
+1 💚	shadedclient	18m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 57s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		80m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux d9cddb0931da 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cdc9ccb`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-07T00:17:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	17m 14s		trunk passed
+1 💚	compile	2m 17s		trunk passed
+1 💚	mvnsite	0m 32s		trunk passed
+1 💚	shadedclient	39m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s		the patch passed
+1 💚	compile	2m 3s		the patch passed
+1 💚	cc	2m 3s		the patch passed
+1 💚	golang	2m 3s		the patch passed
+1 💚	javac	2m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 19s		the patch passed
+1 💚	shadedclient	18m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 55s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		70m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 33756636e45c 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cdc9ccb`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/
Max. process+thread count	550 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-07T01:40:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	18m 19s		trunk passed
+1 💚	compile	2m 7s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	2m 7s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	mvnsite	0m 20s		trunk passed
+1 💚	shadedclient	43m 8s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s		the patch passed
+1 💚	compile	2m 2s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	cc	2m 2s		the patch passed
+1 💚	golang	2m 2s		the patch passed
+1 💚	javac	2m 2s		the patch passed
+1 💚	compile	2m 2s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	cc	2m 2s		the patch passed
+1 💚	golang	2m 2s		the patch passed
+1 💚	javac	2m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shadedclient	20m 1s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 52s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		82m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile
GITHUB PR	#6969
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 73c732c2f04b 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cdc9ccb`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

kevincai · 2024-08-07T01:45:48Z

Finally, the ci check passed

@zhengchenyu @tomscut whom else shall be invited to review this pull request?

Hexiaoqiao

Great catch. Thanks @kevincai for your works. Leave some nit comments inline. PFYI.

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c

...dfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/libhdfs_getjni_test.cc

Hexiaoqiao

LGTM. +1 from my side.

Hexiaoqiao · 2024-08-25T08:49:33Z

Committed to trunk. Thanks @kevincai for your contributions!

BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

kevincai · 2024-08-28T04:51:38Z

Committed to trunk. Thanks @kevincai for your contributions!

BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

steveloughran · 2024-08-28T19:37:58Z

@Hexiaoqiao you want to get into hadoop branch 3.4, so target 3.4.2?

Hexiaoqiao · 2024-09-03T03:06:51Z

@steveloughran No plan to backport to other active branches if no more requirement.

so target 3.4.2?

Not see any place marked 3.4.2, would you mind to confirm? Thanks.

Hexiaoqiao · 2024-09-03T03:08:33Z

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

What about apply one at JIRA side? @kevincai

kevincai · 2024-09-04T00:29:40Z

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

What about apply one at JIRA side? @kevincai

Got the jira account created, please assign to me as kevin.cai

steveloughran · 2024-09-04T12:19:06Z

Not see any place marked 3.4.2, would you mind to confirm? Thanks.

branch-3.4 is going to be where 3.4.2 is going to be forked from -if you do a PR for that branch it'll be out on the relevant release

…#6969). Contributed by Kevin Cai. Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 5745a7d)

Hexiaoqiao · 2024-09-08T08:52:27Z

Not see any place marked 3.4.2, would you mind to confirm? Thanks.

branch-3.4 is going to be where 3.4.2 is going to be forked from -if you do a PR for that branch it'll be out on the relevant release

Hi @steveloughran , have cherrypick to branch-3.4, Please double check.

steveloughran · 2024-09-09T15:13:20Z

@Hexiaoqiao looks good. you want to try for branch-3.4.1. too?

…apache#6969). Contributed by Kevin Cai. Signed-off-by: He Xiaoqiao <[email protected]>

GauthamBanasandra · 2024-10-02T17:45:51Z

@kevincai , @Hexiaoqiao , @steveloughran this PR is causing the Windows CI to fail. Please see - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/647/artifact/out/patch-mvninstall-root.txt

Here's the error -

[exec] "C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\ALL_BUILD.vcxproj" (default target) (1) ->
[exec] "C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj" (default target) (40) ->
[exec] (ClCompile target) -> 
[exec]   C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\tests\libhdfs_getjni_test.cc(24,73): error C2491: 'JNI_GetDefaultJavaVMInitArgs': definition of dllimport function not allowed [C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj]
[exec]   C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\tests\libhdfs_getjni_test.cc(29,79): error C2491: 'JNI_CreateJavaVM': definition of dllimport function not allowed [C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj]

Could you please fix this or revert this PR?

GauthamBanasandra · 2024-10-02T20:20:34Z

@kevincai , @Hexiaoqiao , @steveloughran I've attempted a fix for this in #7096. Let's see if it works.

GauthamBanasandra · 2024-10-02T20:21:58Z

Started the Windows CI run for the fix - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/652/.

github-actions bot added HDFS trunk Native labels Jul 31, 2024

kevincai force-pushed the fix-HDFS-16084 branch from 2e1c2c6 to f6dc302 Compare August 5, 2024 20:52

kevincai force-pushed the fix-HDFS-16084 branch from f6dc302 to e330ff4 Compare August 6, 2024 00:05

kevincai force-pushed the fix-HDFS-16084 branch from e330ff4 to e7383eb Compare August 6, 2024 02:07

kevincai force-pushed the fix-HDFS-16084 branch from e7383eb to a031775 Compare August 6, 2024 05:39

kevincai force-pushed the fix-HDFS-16084 branch from a031775 to b99bd3e Compare August 6, 2024 16:52

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var

cdc9ccb

kevincai force-pushed the fix-HDFS-16084 branch from b99bd3e to cdc9ccb Compare August 6, 2024 20:19

Hexiaoqiao reviewed Aug 18, 2024

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c Show resolved Hide resolved

...dfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/libhdfs_getjni_test.cc Show resolved Hide resolved

Hexiaoqiao approved these changes Aug 25, 2024

View reviewed changes

Hexiaoqiao merged commit 5745a7d into apache:trunk Aug 25, 2024

Hexiaoqiao pushed a commit that referenced this pull request Sep 8, 2024

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var (…

87e4b0a

…#6969). Contributed by Kevin Cai. Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 5745a7d)

KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var (…

0b3f89c

…apache#6969). Contributed by Kevin Cai. Signed-off-by: He Xiaoqiao <[email protected]>

Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var (…

2e1658c

…apache#6969). Contributed by Kevin Cai. Signed-off-by: He Xiaoqiao <[email protected]>

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var #6969

HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var #6969

Uh oh!

Conversation

kevincai commented Jul 31, 2024

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jul 31, 2024

Uh oh!

kevincai commented Aug 1, 2024

Uh oh!

zhengchenyu commented Aug 2, 2024

Uh oh!

kevincai commented Aug 2, 2024

Uh oh!

tomscut commented Aug 5, 2024

Uh oh!

hadoop-yetus commented Aug 5, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 6, 2024

Uh oh!

hadoop-yetus commented Aug 7, 2024

Uh oh!

hadoop-yetus commented Aug 7, 2024

Uh oh!

kevincai commented Aug 7, 2024

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Hexiaoqiao commented Aug 25, 2024

Uh oh!

kevincai commented Aug 28, 2024

Uh oh!

steveloughran commented Aug 28, 2024

Uh oh!

Hexiaoqiao commented Sep 3, 2024

Uh oh!

Hexiaoqiao commented Sep 3, 2024

Uh oh!

kevincai commented Sep 4, 2024

Uh oh!

steveloughran commented Sep 4, 2024

Uh oh!

Hexiaoqiao commented Sep 8, 2024

Uh oh!

steveloughran commented Sep 9, 2024

Uh oh!

GauthamBanasandra commented Oct 2, 2024

Uh oh!

GauthamBanasandra commented Oct 2, 2024

Uh oh!

GauthamBanasandra commented Oct 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants