-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17636. Don't add declspec for Windows #7096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Windows doesn't want the macro _JNI_IMPORT_OR_EXPORT_ to be defined in the function definition. It fails to compile with the following error - "definition of dllimport function not allowed". * However, Linux needs it. Hence, we're going to add this macro based on the OS.
|
+1. @GauthamBanasandra I'm not familiar with this part, but you're very knowledgeable about Hadoop on Windows. I believe your changes should be fine. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Started Windows CI on this PR - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/654/ |
|
Does Hadoop support native compilation on Windows? |
|
Thanks for the fix! |
| SOVERSION ${LIBHDFS_VERSION}) | ||
|
|
||
| build_libhdfs_test(test_libhdfs_ops hdfs_static test_libhdfs_ops.c) | ||
| build_libhdfs_test(test_libhdfs_ops hdfs_static test_libhdfs_ops.c ../libhdfs/hdfs.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought hdfs_static includes the libhdfs/hdfs.c object file, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was testing something locally and I had to add this. I'll remove this before merging.
@kevincai the Windows CI failed to build the HDFS native client due to the following error - The error seems valid. You've defined Were you trying to override the definition for |
OK. want to override the real JNI_CreateJavaVM with my own mock version in order to simulate consistent failure of invoking the interface. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Windows CI is passing with this PR - Logs - |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I've started a final CI run on Windows - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/675/console. I'll merge this PR once this run finishes. |
|
Windows CI run is passing - Logs - |


Description of PR
How was this patch tested?
Jenkins CI validation.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?