HDDS-1473. DataNode ID file should be human readable. #781

swagle · 2019-04-28T16:33:28Z

cc: @arp7 Human readable version of the dn details will now be written out like this::

!!org.apache.hadoop.ozone.container.common.helpers.DatanodeIdYaml$DatanodeDetailsYaml { certSerialId: '8689088562908158976', hostName: localhost, ipAddress: 155.217.19.151, portDetails: { RATIS: 0, REST: 0, STANDALONE: 1 }, uuid: 74737b50-7b2b-448b-8a72-f2c6c6c77e4a }

...r-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java

hadoop-yetus · 2019-04-28T18:25:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	71	Maven dependency ordering for branch
+1	mvninstall	1054	trunk passed
+1	compile	1015	trunk passed
+1	checkstyle	146	trunk passed
+1	mvnsite	138	trunk passed
+1	shadedclient	1015	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	62	trunk passed
+1	javadoc	75	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
+1	mvninstall	70	the patch passed
+1	compile	936	the patch passed
+1	javac	936	the patch passed
+1	checkstyle	140	the patch passed
+1	mvnsite	96	the patch passed
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	685	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	69	the patch passed
+1	javadoc	71	the patch passed
		_ Other Tests _
-1	unit	76	container-service in the patch failed.
-1	unit	841	integration-test in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		6653

Reason	Tests
Failed junit tests	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.client.rpc.TestReadRetries

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/artifact/out/Dockerfile
GITHUB PR	#781
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 91b31a5b0b73 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `43b2a4b`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/testReport/
Max. process+thread count	4929 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-04-28T22:30:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	27	Maven dependency ordering for branch
+1	mvninstall	1129	trunk passed
+1	compile	981	trunk passed
+1	checkstyle	146	trunk passed
+1	mvnsite	157	trunk passed
+1	shadedclient	1079	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	57	trunk passed
+1	javadoc	61	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
+1	mvninstall	67	the patch passed
+1	compile	934	the patch passed
+1	javac	934	the patch passed
+1	checkstyle	143	the patch passed
+1	mvnsite	81	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	742	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	62	the patch passed
+1	javadoc	59	the patch passed
		_ Other Tests _
-1	unit	68	container-service in the patch failed.
-1	unit	1052	integration-test in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		6893

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-781/2/artifact/out/Dockerfile
GITHUB PR	#781
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e6e4f7bb239c 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `43b2a4b`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/2/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/2/testReport/
Max. process+thread count	4394 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

arp7

+1 with two nitpicky comments! Thanks for fixing this @swagle .

...r-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneCluster.java

hadoop-yetus · 2019-04-30T00:34:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	868	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	78	Maven dependency ordering for branch
+1	mvninstall	1106	trunk passed
+1	compile	1104	trunk passed
+1	checkstyle	142	trunk passed
+1	mvnsite	121	trunk passed
+1	shadedclient	981	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	56	trunk passed
+1	javadoc	61	trunk passed
		_ Patch Compile Tests _
0	mvndep	24	Maven dependency ordering for patch
+1	mvninstall	68	the patch passed
+1	compile	1064	the patch passed
+1	javac	1064	the patch passed
+1	checkstyle	142	the patch passed
+1	mvnsite	80	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	693	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	65	the patch passed
+1	javadoc	69	the patch passed
		_ Other Tests _
-1	unit	76	container-service in the patch failed.
-1	unit	1349	integration-test in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		8188

Reason	Tests
Failed junit tests	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-781/3/artifact/out/Dockerfile
GITHUB PR	#781
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7d183442229d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 4b4200f
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/3/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/3/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/3/testReport/
Max. process+thread count	4791 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hanishakoneru · 2019-04-30T22:08:44Z

LGTM. +1 pending CI checks.

swagle · 2019-04-30T22:32:49Z

Thanks, @hanishakoneru for the review. Made checkstyle fixes in the last push.

hadoop-yetus · 2019-05-01T00:38:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	74	Maven dependency ordering for branch
+1	mvninstall	1320	trunk passed
+1	compile	1412	trunk passed
+1	checkstyle	166	trunk passed
+1	mvnsite	141	trunk passed
+1	shadedclient	1189	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	60	trunk passed
+1	javadoc	62	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	67	the patch passed
+1	compile	935	the patch passed
+1	javac	935	the patch passed
+1	checkstyle	185	the patch passed
+1	mvnsite	90	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	747	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	65	the patch passed
+1	javadoc	61	the patch passed
		_ Other Tests _
-1	unit	72	container-service in the patch failed.
-1	unit	807	integration-test in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		7503

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOmInit
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.om.TestOzoneManagerRestInterface
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.om.TestOMDbCheckpointServlet
	hadoop.ozone.om.TestOmMetrics
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.scm.node.TestSCMNodeMetrics
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.TestContainerOperations

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-781/4/artifact/out/Dockerfile
GITHUB PR	#781
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 19a3851ea1f3 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 4877f0a
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/4/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/4/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/4/testReport/
Max. process+thread count	4449 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-781/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

swagle · 2019-05-02T17:10:07Z

/retest

hanishakoneru · 2019-05-02T20:35:11Z

The test failures are unrelated and pass locally. I will merge this PR. Thank you @swagle for working on this.

Author: Sanil15 <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#781 from Sanil15/SAMZA-1970

hadoop-yetus reviewed Apr 28, 2019

View reviewed changes

...r-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java Outdated Show resolved Hide resolved

arp7 approved these changes Apr 29, 2019

View reviewed changes

hanishakoneru added the ozone label Apr 30, 2019

swagle added 4 commits April 30, 2019 15:24

HDDS-1473. DataNode ID file should be human readable.

24f88d7

HDDS-1473. Whitespace fix.

f30e4a8

HDDS-1473. Minor fixes.

8a4facb

HDDS-1473. Checkstyle fixes.

763572b

swagle force-pushed the HDDS-1473 branch from bfa6216 to 763572b Compare April 30, 2019 22:31

vivekratnavel approved these changes May 2, 2019

View reviewed changes

hanishakoneru merged commit 1df6799 into apache:trunk May 2, 2019

swagle mentioned this pull request May 4, 2019

HDDS-1464. Client should have different retry policies for different exceptions. #785

Merged

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019

Add physical name support for InMemoryStreamDescriptors

64c8263

Author: Sanil15 <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#781 from Sanil15/SAMZA-1970

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1473. DataNode ID file should be human readable. #781

HDDS-1473. DataNode ID file should be human readable. #781

Uh oh!

swagle commented Apr 28, 2019

Uh oh!

Uh oh!

hadoop-yetus commented Apr 28, 2019

Uh oh!

hadoop-yetus commented Apr 28, 2019

Uh oh!

arp7 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Apr 30, 2019

Uh oh!

hanishakoneru commented Apr 30, 2019

Uh oh!

swagle commented Apr 30, 2019

Uh oh!

hadoop-yetus commented May 1, 2019

Uh oh!

swagle commented May 2, 2019

Uh oh!

hanishakoneru commented May 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDDS-1473. DataNode ID file should be human readable. #781

HDDS-1473. DataNode ID file should be human readable. #781

Uh oh!

Conversation

swagle commented Apr 28, 2019

Uh oh!

Uh oh!

hadoop-yetus commented Apr 28, 2019

Uh oh!

hadoop-yetus commented Apr 28, 2019

Uh oh!

arp7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Apr 30, 2019

Uh oh!

hanishakoneru commented Apr 30, 2019

Uh oh!

swagle commented Apr 30, 2019

Uh oh!

hadoop-yetus commented May 1, 2019

Uh oh!

swagle commented May 2, 2019

Uh oh!

hanishakoneru commented May 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants