-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDDS-1473. DataNode ID file should be human readable. #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
182 changes: 182 additions & 0 deletions
182
...ervice/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.ozone.container.common.helpers; | ||
|
|
||
| import java.io.File; | ||
| import java.io.FileInputStream; | ||
| import java.io.FileOutputStream; | ||
| import java.io.IOException; | ||
| import java.io.OutputStreamWriter; | ||
| import java.io.Writer; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
|
|
||
| import org.apache.commons.collections.CollectionUtils; | ||
| import org.apache.commons.collections.MapUtils; | ||
| import org.apache.hadoop.hdds.protocol.DatanodeDetails; | ||
| import org.yaml.snakeyaml.DumperOptions; | ||
| import org.yaml.snakeyaml.Yaml; | ||
|
|
||
| /** | ||
| * Class for creating datanode.id file in yaml format. | ||
| */ | ||
| public final class DatanodeIdYaml { | ||
|
|
||
| private DatanodeIdYaml() { | ||
| // static helper methods only, no state. | ||
| } | ||
|
|
||
| /** | ||
| * Creates a yaml file using DatnodeDetails. This method expects the path | ||
| * validation to be performed by the caller. | ||
| * | ||
| * @param datanodeDetails {@link DatanodeDetails} | ||
| * @param path Path to datnode.id file | ||
| */ | ||
| public static void createDatanodeIdFile(DatanodeDetails datanodeDetails, | ||
| File path) throws IOException { | ||
| DumperOptions options = new DumperOptions(); | ||
| options.setPrettyFlow(true); | ||
| options.setDefaultFlowStyle(DumperOptions.FlowStyle.FLOW); | ||
| Yaml yaml = new Yaml(options); | ||
|
|
||
| try (Writer writer = new OutputStreamWriter( | ||
| new FileOutputStream(path), "UTF-8")) { | ||
| yaml.dump(getDatanodeDetailsYaml(datanodeDetails), writer); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Read datanode.id from file. | ||
| */ | ||
| public static DatanodeDetails readDatanodeIdFile(File path) | ||
| throws IOException { | ||
| DatanodeDetails datanodeDetails; | ||
| try (FileInputStream inputFileStream = new FileInputStream(path)) { | ||
| Yaml yaml = new Yaml(); | ||
| DatanodeDetailsYaml datanodeDetailsYaml; | ||
| try { | ||
| datanodeDetailsYaml = | ||
| yaml.loadAs(inputFileStream, DatanodeDetailsYaml.class); | ||
| } catch (Exception e) { | ||
| throw new IOException("Unable to parse yaml file.", e); | ||
| } | ||
|
|
||
| DatanodeDetails.Builder builder = DatanodeDetails.newBuilder(); | ||
| builder.setUuid(datanodeDetailsYaml.getUuid()) | ||
| .setIpAddress(datanodeDetailsYaml.getIpAddress()) | ||
| .setHostName(datanodeDetailsYaml.getHostName()) | ||
| .setCertSerialId(datanodeDetailsYaml.getCertSerialId()); | ||
|
|
||
| if (!MapUtils.isEmpty(datanodeDetailsYaml.getPortDetails())) { | ||
| for (Map.Entry<String, Integer> portEntry : | ||
| datanodeDetailsYaml.getPortDetails().entrySet()) { | ||
| builder.addPort(DatanodeDetails.newPort( | ||
| DatanodeDetails.Port.Name.valueOf(portEntry.getKey()), | ||
| portEntry.getValue())); | ||
| } | ||
| } | ||
| datanodeDetails = builder.build(); | ||
| } | ||
|
|
||
| return datanodeDetails; | ||
| } | ||
|
|
||
| /** | ||
| * Datanode details bean to be written to the yaml file. | ||
| */ | ||
| public static class DatanodeDetailsYaml { | ||
| private String uuid; | ||
| private String ipAddress; | ||
| private String hostName; | ||
| private String certSerialId; | ||
| private Map<String, Integer> portDetails; | ||
|
|
||
| public DatanodeDetailsYaml() { | ||
| // Needed for snake-yaml introspection. | ||
| } | ||
|
|
||
| private DatanodeDetailsYaml(String uuid, String ipAddress, | ||
| String hostName, String certSerialId, | ||
| Map<String, Integer> portDetails) { | ||
| this.uuid = uuid; | ||
| this.ipAddress = ipAddress; | ||
| this.hostName = hostName; | ||
| this.certSerialId = certSerialId; | ||
| this.portDetails = portDetails; | ||
| } | ||
|
|
||
| public String getUuid() { | ||
| return uuid; | ||
| } | ||
|
|
||
| public String getIpAddress() { | ||
| return ipAddress; | ||
| } | ||
|
|
||
| public String getHostName() { | ||
| return hostName; | ||
| } | ||
|
|
||
| public String getCertSerialId() { | ||
| return certSerialId; | ||
| } | ||
|
|
||
| public Map<String, Integer> getPortDetails() { | ||
| return portDetails; | ||
| } | ||
|
|
||
| public void setUuid(String uuid) { | ||
| this.uuid = uuid; | ||
| } | ||
|
|
||
| public void setIpAddress(String ipAddress) { | ||
| this.ipAddress = ipAddress; | ||
| } | ||
|
|
||
| public void setHostName(String hostName) { | ||
| this.hostName = hostName; | ||
| } | ||
|
|
||
| public void setCertSerialId(String certSerialId) { | ||
| this.certSerialId = certSerialId; | ||
| } | ||
|
|
||
| public void setPortDetails(Map<String, Integer> portDetails) { | ||
| this.portDetails = portDetails; | ||
| } | ||
| } | ||
|
|
||
| private static DatanodeDetailsYaml getDatanodeDetailsYaml( | ||
| DatanodeDetails datanodeDetails) { | ||
|
|
||
| Map<String, Integer> portDetails = new LinkedHashMap<>(); | ||
| if (!CollectionUtils.isEmpty(datanodeDetails.getPorts())) { | ||
| for (DatanodeDetails.Port port : datanodeDetails.getPorts()) { | ||
| portDetails.put(port.getName().toString(), port.getValue()); | ||
| } | ||
| } | ||
|
|
||
| return new DatanodeDetailsYaml( | ||
| datanodeDetails.getUuid().toString(), | ||
| datanodeDetails.getIpAddress(), | ||
| datanodeDetails.getHostName(), | ||
| datanodeDetails.getCertSerialId(), | ||
| portDetails); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.