-
Notifications
You must be signed in to change notification settings - Fork 59
feat: implement literal expressions with binary serialization support #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c53971
to
9a134e0
Compare
wgtmac
suggested changes
Aug 23, 2025
mapleFU
reviewed
Aug 23, 2025
e177e7e
to
6402f18
Compare
wgtmac
reviewed
Aug 25, 2025
wgtmac
suggested changes
Aug 26, 2025
b70c166
to
4084db1
Compare
wgtmac
suggested changes
Sep 1, 2025
16d9821
to
7525f27
Compare
wgtmac
suggested changes
Sep 12, 2025
63063c2
to
7a73d6c
Compare
7a73d6c
to
cfc55d6
Compare
zhjwpku
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HuaHuaY
reviewed
Sep 23, 2025
HuaHuaY
approved these changes
Sep 23, 2025
wgtmac
reviewed
Sep 25, 2025
@wgtmac I've handled these comments. |
wgtmac
reviewed
Sep 25, 2025
wgtmac
reviewed
Sep 26, 2025
9dc8182
to
7d05340
Compare
wgtmac
approved these changes
Sep 29, 2025
7d05340
to
5ff897e
Compare
5ff897e
to
bce09c6
Compare
wgtmac
approved these changes
Oct 10, 2025
Fokko
approved these changes
Oct 10, 2025
Looks good @HeartLinked, thanks for working on this, and thanks @wgtmac @zhjwpku @mapleFU and @HuaHuaY for the review 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements binary serialization and deserialization support for Literal values, enabling conversion between Literal objects and binary representations. Adds comprehensive formatting support for date, time, and timestamp types.
Changes
Conversions
utility class (src/iceberg/util/conversions.cc/h
) withToBytes()
andFromBytes()
methods forLiteral
binary serialization/deserializationsrc/iceberg/util/literal_format.cc/h
) fordate
,time
,timestamp
, andtimestamptz
formattingLiteral
serialization methods: Replaced placeholder implementations ofSerialize()
andDeserialize()
with full functionalityLiteral::ToString()
: Added support fordate
,time
,timestamp
, andtimestamptz
typesTypeId
string conversion: ImplementedToString(TypeId)
utility function for type name lookupsTest Plan