-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Implement Type Casting and toString for Literals #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HeartLinked
wants to merge
7
commits into
apache:main
Choose a base branch
from
HeartLinked:feat/literal2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b599a7a
to
9dfc38a
Compare
nullccxsy
reviewed
Sep 4, 2025
3f912eb
to
59e57fc
Compare
wgtmac
suggested changes
Sep 9, 2025
cf43748
to
406a3f2
Compare
wgtmac
suggested changes
Sep 11, 2025
wgtmac
reviewed
Sep 11, 2025
nullccxsy
reviewed
Sep 12, 2025
406a3f2
to
9525400
Compare
a62ac22
to
1e106ed
Compare
HuaHuaY
reviewed
Sep 23, 2025
HuaHuaY
reviewed
Sep 23, 2025
HuaHuaY
reviewed
Sep 23, 2025
2beaf96
to
632ec79
Compare
wgtmac
reviewed
Sep 23, 2025
wgtmac
reviewed
Sep 24, 2025
wgtmac
suggested changes
Sep 29, 2025
case TypeId::kTimestamp: | ||
case TypeId::kTimestampTz: { | ||
throw IcebergError("Not implemented: ToString for " + type_->ToString()); | ||
return std::to_string(std::get<int64_t>(value_)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these switch cases can be easily rewritten by return std::to_string(std::get<typename LiteralTraits<type_id>::ValueType>(value_));
once #185 is merged.
a194923
to
0abbf84
Compare
wgtmac
approved these changes
Oct 10, 2025
Fokko
approved these changes
Oct 10, 2025
336e03b
to
56088c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iceberg::Literal
in theLiteralCaster
class to align with the Java reference implementation. This is critical for expression evaluation and predicate pushdown.ToString()
to match Java's output format for better consistency (e.g.,X'...'
for binary).ToString()
formatting.