[SPARK-12445][SQL] Fix NullPointerException when passing null as array #10401
Conversation
|
Test build #48079 has finished for PR 10401 at commit
|
There was a problem hiding this comment.
Can this test be done with the encoder tests?
|
Test build #48196 has finished for PR 10401 at commit
|
|
retest this please. |
|
retest this please. |
|
Test build #48228 has finished for PR 10401 at commit
|
|
ping @marmbrus @davies @cloud-fan Can you see if this patch is ok to merge? Thanks. |
There was a problem hiding this comment.
A simple idea is to set propafateNull = true for NewInstance, and it's also fixed in #10443 which makes false as default value for propagateNull.
There was a problem hiding this comment.
ok. I think this can be closed.
There was a problem hiding this comment.
Will #10443 be merged soon? I think I have another pr depending this fixing.
…Instance Most of cases we should propagate null when call `NewInstance`, and so far there is only one case we should stop null propagation: create product/java bean. So I think it makes more sense to propagate null by dafault. This also fixes a bug when encode null array/map, which is firstly discovered in #10401 Author: Wenchen Fan <[email protected]> Closes #10443 from cloud-fan/encoder.
…Instance Most of cases we should propagate null when call `NewInstance`, and so far there is only one case we should stop null propagation: create product/java bean. So I think it makes more sense to propagate null by dafault. This also fixes a bug when encode null array/map, which is firstly discovered in apache#10401 Author: Wenchen Fan <[email protected]> Closes apache#10443 from cloud-fan/encoder.
4 participants
JIRA: https://issues.apache.org/jira/browse/SPARK-12445
Current
toCatalystArraydoesn't check if given array is null or not. We should check it to prevent java.lang.NullPointerException.