[SPARK-12495][SQL] use true as default value for propagateNull in NewInstance #10443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #48233 has finished for PR 10443 at commit
|
Contributor
Author
There was a problem hiding this comment.
a small fix: we should not go into this branch if argGen is empty, or the argsNonNull will be !(), which is wrong.
I found this when I leave the propagateNull true for NewInstance of UDT.
|
Test build #48242 has finished for PR 10443 at commit
|
|
Test build #48389 has finished for PR 10443 at commit
|
Contributor
|
Thanks, merging to master. |
marmbrus
pushed a commit
to marmbrus/spark
that referenced
this pull request
Jan 7, 2016
…Instance Most of cases we should propagate null when call `NewInstance`, and so far there is only one case we should stop null propagation: create product/java bean. So I think it makes more sense to propagate null by dafault. This also fixes a bug when encode null array/map, which is firstly discovered in apache#10401 Author: Wenchen Fan <[email protected]> Closes apache#10443 from cloud-fan/encoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of cases we should propagate null when call
NewInstance, and so far there is only one case we should stop null propagation: create product/java bean. So I think it makes more sense to propagate null by dafault.This also fixes a bug when encode null array/map, which is firstly discovered in #10401