[SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a fetchSize #18515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maver1ck
changed the title
|
See JIRA; I don't think we should allow this. |
|
Test build #79100 has finished for PR 18515 at commit
|
gatorsmile
reviewed
Jul 3, 2017
| val fetchSize = { | ||
| val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt | ||
| require(size >= 0, | ||
| require(size >= 0 || size == Integer.MIN_VALUE, |
There was a problem hiding this comment.
It does not make sense to the other data sources except MySQL. If needed, we can introduce a dialect specific checking APIs in JdbcDialect.scala
There was a problem hiding this comment.
+1 for @gatorsmile 's suggestion.
|
@maver1ck Any update? |
|
Test build #81467 has finished for PR 18515 at commit
|
srowen
added a commit
to srowen/spark
that referenced
this pull request
Sep 12, 2017
Closes apache#18522 Closes apache#17722 Closes apache#18879 Closes apache#18891 Closes apache#18806 Closes apache#18948 Closes apache#18949 Closes apache#19070 Closes apache#19039 Closes apache#19142 Closes apache#18515 Closes apache#19154 Closes apache#19162 Closes apache#19187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
FIX for https://issues.apache.org/jira/browse/SPARK-21287
How was this patch tested?
Existing automated tests + manual tests.