[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of [SparkSQL::lP] #18879
Conversation
… of [SparkSQL::lP]
|
Can one of the admins verify this patch? |
|
I'm not convinced this deserves a separated PR because it's neither bugfix nor any improvement. Further more, the method |
|
The method name is misleading internally, but we can't change this logic. |
|
@srowen @jiangxb1987 |
|
@srowen |
| if (sqlContext == null) { | ||
| val sparkConf = new SparkConf(loadDefaults = true) | ||
| // If user doesn't specify the appName, we want to get [SparkSQL::localHostName] instead of | ||
| // If user doesn't specify the appName, we will get [SparkSQL::IP] instead of |
There was a problem hiding this comment.
What is SparkSQL::IP?
I think this is not worth a JIRA / PR relative to the time spent looking at it
What problem does this cause a user?
There was a problem hiding this comment.
@srowen
It is not accurate,because the comment is different from the appname in web UI.
|
I think @srowen means you should change the method name, not only the comment. |
|
Thanks for your patience.Would you @srowen agree with @jiangxb1987 . |
|
@jiangxb1987 |
Closes apache#18522 Closes apache#17722 Closes apache#18879 Closes apache#18891 Closes apache#18806 Closes apache#18948 Closes apache#18949 Closes apache#19070 Closes apache#19039 Closes apache#19142 Closes apache#18515 Closes apache#19154 Closes apache#19162 Closes apache#19187
3 participants
https://issues.apache.org/jira/browse/SPARK-21662
As it says "If user doesn't specify the appName, we want to get [SparkSQL::localHostName]" in SparkSqlEnv.scala,line 38,appname should be SparkSQL::localHostName,but it is SparkSQL::lP in fact.So I modify the localHostName method to get localhost with getCanonicalHostName method.