Skip to content

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of [SparkSQL::lP] #18879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of [SparkSQL::lP] #18879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab22485
[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead…
liu-zhaokun Aug 8, 2017
df1bdc0
modify the annotation
liu-zhaokun Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ private[hive] object SparkSQLEnv extends Logging {
def init() {
if (sqlContext == null) {
val sparkConf = new SparkConf(loadDefaults = true)
// If user doesn't specify the appName, we want to get [SparkSQL::localHostName] instead of
// If user doesn't specify the appName, we will get [SparkSQL::IP] instead of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SparkSQL::IP?
I think this is not worth a JIRA / PR relative to the time spent looking at it
What problem does this cause a user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen
It is not accurate,because the comment is different from the appname in web UI.

// the default appName [SparkSQLCLIDriver] in cli or beeline.
val maybeAppName = sparkConf
.getOption("spark.app.name")
Expand Down