[SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark #46740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .start() | ||
| ) | ||
| self.assertTrue(q1.isActive) | ||
| time.sleep(20) |
There was a problem hiding this comment.
20 seconds is necessary to make sure the task run at least once.
|
@eason-yuchen-liu - same here. seems like the GH actions is not running the tests as expected ? |
|
cc - @HeartSaVioR |
|
@eason-yuchen-liu, could you please setup the CI as shown in the error message https://github.com/apache/spark/pull/46740/checks?check_run_id=25522033987 |
…a test file for time series & refactor the test file layout
eason-yuchen-liu
force-pushed
the
DropDuplicateWithinWatermark_test
branch
from
c80987f to
7d031b8
Compare
WweiL
reviewed
May 30, 2024
WweiL
reviewed
May 30, 2024
WweiL
reviewed
May 30, 2024
WweiL
reviewed
May 30, 2024
WweiL
approved these changes
May 31, 2024
anishshri-db
reviewed
Jun 5, 2024
| .csv("python/test_support/sql/streaming/time") | ||
| ) | ||
| q1 = ( | ||
| df.withWatermark("time", "2 seconds") |
There was a problem hiding this comment.
Nit: can you move withWatermark and outputMode to new lines ? Thx
anishshri-db
approved these changes
Jun 5, 2024
|
Thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a test for API DropDuplicateWithinWatermark in Python, which was previously missing.
Why are the changes needed?
Check the correctness of API DropDuplicateWithinWatermark.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passed:
Was this patch authored or co-authored using generative AI tooling?
No.