Skip to content

[SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark #46740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark #46740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
119451f
empty commit
eason-yuchen-liu May 24, 2024
7d031b8
in pyspark, create a test for dropDuplicatesWithinWatermark & create …
eason-yuchen-liu May 28, 2024
8171696
rollback the change to the test support files layout
eason-yuchen-liu May 29, 2024
ef59b2f
address python linter issue
eason-yuchen-liu May 30, 2024
b480260
address comments
eason-yuchen-liu May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion python/pyspark/sql/tests/streaming/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from pyspark.sql import Row
from pyspark.sql.functions import lit
from pyspark.sql.types import StructType, StructField, IntegerType, StringType
from pyspark.sql.types import StructType, StructField, IntegerType, StringType, TimestampType
from pyspark.testing.sqlutils import ReusedSQLTestCase


Expand Down Expand Up @@ -392,6 +392,30 @@ def test_streaming_with_temporary_view(self):
set([Row(value="view_a"), Row(value="view_b"), Row(value="view_c")]), set(result)
)

def test_streaming_drop_duplicate_within_watermark(self):
"""
This verifies dropDuplicatesWithinWatermark works with a streaming dataframe.
"""
user_schema = StructType().add("time", TimestampType()).add("id", "integer")
df = (
self.spark.readStream.option("sep", ";")
.schema(user_schema)
.csv("python/test_support/sql/streaming/time")
)
q1 = (
df.withWatermark("time", "2 seconds")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you move withWatermark and outputMode to new lines ? Thx

.dropDuplicatesWithinWatermark(["id"])
.writeStream.outputMode("update")
.format("memory")
.queryName("test_streaming_drop_duplicates_within_wm")
.start()
)
self.assertTrue(q1.isActive)
q1.processAllAvailable()
q1.stop()
result = self.spark.sql("SELECT * FROM test_streaming_drop_duplicates_within_wm").collect()
self.assertTrue(len(result) >= 6 and len(result) <= 9)


class StreamingTests(StreamingTestsMixin, ReusedSQLTestCase):
def _assert_exception_tree_contains_msg(self, exception, msg):
Expand Down
10 changes: 10 additions & 0 deletions python/test_support/sql/streaming/time/text-with-time-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
2024-05-24 15:03:20;1
2024-05-24 15:03:21;2
2024-05-24 15:03:24;3
2024-05-24 15:03:25;3
2024-05-24 15:03:31;4
2024-05-24 15:03:31;1
2024-05-24 15:03:32;3
2024-05-24 15:03:45;2
2024-05-24 15:03:46;5
2024-05-24 15:03:50;6