[TVMScript] Allow T.Buffer[] arg annotation to use int as shape #11454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the function `tvm.tir.decl_buffer` and the TVMScript `T.match_buffer` expression allow a `PrimExpr` to be passed as the buffer shape, which is interpreted as a 1-d buffer of that size. This allows the same behavior to be used in the `T.Buffer` syntactic sugar. (e.g. `A: T.Buffer[16, "float32"]` instead of `A: T.Buffer[(16,), "float32"`)
vinx13
approved these changes
May 25, 2022
Contributor
Author
|
Retriggering CI following #11456. |
Contributor
Author
|
Retriggering CI following tlc-pack/ci-packer#5. |
Lunderberg
force-pushed
the
tvmscript_buffer_1d_sugar
branch
from
0925886 to
92e138e
Compare
areusch
pushed a commit
that referenced
this pull request
Jun 1, 2022
This improves the parsing to avoid issues like in #11454 commit-id:53a06ab3 Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the function
tvm.tir.decl_bufferand the TVMScriptT.match_bufferexpression allow aPrimExprto be passed as the buffer shape, which is interpreted as a 1-d buffer of that size. This allows the same behavior to be used in theT.Buffersyntactic sugar.(e.g.
A: T.Buffer[16, "float32"]instead ofA: T.Buffer[(16,), "float32"])cc @driazati