[TIR] Merged kDeviceThreadAxis and kUseDynamicSharedMemoryTag #14495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `kDeviceThreadAxis` defined the IterVar to be used for each thread/block axis, and `kUseDynamicSharedMemoryTag` defined whether dynamic memory allocations exist, which are primarily used to produce a list of strings by `tvm::codegen::ExtractFuncInfo`. Because `kDeviceThreadAxis` is a `Array<IterVar>`, the IterVar is used prior to its definition site at `tir::attr::thread_extent`, which results in errors when attempting to round-trip through TVMScript. This commit replaces these attributes with `attr::kKernelLaunchParams`, which directly contains the kernel launch parameters. These are expressed as an `Array<String>`, allowing the generated TVMScript to successfully round-trip.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
@tvm-bot rerun |
vinx13
approved these changes
Apr 5, 2023
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Apr 10, 2023
…#14495) Previously, `kDeviceThreadAxis` defined the IterVar to be used for each thread/block axis, and `kUseDynamicSharedMemoryTag` defined whether dynamic memory allocations exist, which are primarily used to produce a list of strings by `tvm::codegen::ExtractFuncInfo`. Because `kDeviceThreadAxis` is a `Array<IterVar>`, the IterVar is used prior to its definition site at `tir::attr::thread_extent`, which results in errors when attempting to round-trip through TVMScript. This commit replaces these attributes with `attr::kKernelLaunchParams`, which directly contains the kernel launch parameters. These are expressed as an `Array<String>`, allowing the generated TVMScript to successfully round-trip.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Apr 10, 2023
A follow-up from apache#14495, applying the same change in CodeGenWebGPU.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Apr 10, 2023
A follow-up from apache#14495, applying the same change in CodeGenWebGPU.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 12, 2023
A follow-up from apache#14495, applying the same change in CodeGenWebGPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
kDeviceThreadAxisdefined the IterVar to be used for each thread/block axis, andkUseDynamicSharedMemoryTagdefined whether dynamic memory allocations exist, which are primarily used to produce a list of strings bytvm::codegen::ExtractFuncInfo. BecausekDeviceThreadAxisis aArray<IterVar>, the IterVar is used prior to its definition site attir::attr::thread_extent, which results in errors when attempting to round-trip through TVMScript.This commit replaces these attributes with
attr::kKernelLaunchParams, which directly contains the kernel launch parameters. These are expressed as anArray<String>, allowing the generated TVMScript to successfully round-trip.This is part of changes described in #14486, to improve round-trip TVMScript failures that occur in lowering.