[Unity][CODEGEN] Fix metal codegen when with only single working dim #14627
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
cc @Lunderberg was caused by recent merging that bought in #14495 . This is a hotfix, will also need pick to main |
This PR fixes the metal introduces by a previous commit that removes the workdim remapping that caused issues for kernels with only threadIdx.x and blockIdx.x
…pache#14627) [CODEGEN] Fix metal codegen when with only single working dim This PR fixes the metal introduces by a previous commit that removes the workdim remapping that caused issues for kernels with only threadIdx.x and blockIdx.x
|
Thank you for finding the fix, and that makes sense with the different naming based on the number of block/thread dimensions. Do we have any tests of the metal codegen in CI? I was hoping to add a test to catch this failure, but it looks like Metal doesn't currently run on the CI due to being OSX-only. |
|
right i think it should be covered by tests already but was not run due to metal being osx only |
…pache#14627) [CODEGEN] Fix metal codegen when with only single working dim This PR fixes the metal introduces by a previous commit that removes the workdim remapping that caused issues for kernels with only threadIdx.x and blockIdx.x
5 participants
This PR fixes the metal introduces by a previous commit that removes the workdim remapping that caused issues for kernels with only threadIdx.x and blockIdx.x