[WEB] Move ArtifactCache to Interface, Support Cache delete and Batch Delete, Remove typo #16525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
please fix the ci errors |
Contributor
Author
|
Will re-open after supporting batch delete weights |
DiegoCao
force-pushed
the
archi-cache
branch
4 times, most recently
from
23960bd to
4b55a1b
Compare
DiegoCao
changed the title
Member
|
Will take a look tomorrow; thank you @DiegoCao! |
Member
CharlieFRuan
left a comment
CharlieFRuan
left a comment
There was a problem hiding this comment.
The new interface and deleteInCache() looks good to me! Thanks for the changes.
I left some comments on deleteNDArrayCache(), let me know what you think!
DiegoCao
force-pushed
the
archi-cache
branch
3 times, most recently
from
7d61b4a to
4c99370
Compare
Member
CharlieFRuan
left a comment
CharlieFRuan
left a comment
There was a problem hiding this comment.
Everything else looks good, thank you!
…different cache types, fix README path typo, Support delete and batch delete Co-authored-by: DavidGOrtega <[email protected]>
DiegoCao
force-pushed
the
archi-cache
branch
from
4c99370 to
70911c5
Compare
Contributor
Author
|
All issues are resolved, will later pr the corresponding webLLM side API |
Member
|
Thank you! I think this is ready to be merged cc @tqchen |
tqchen
approved these changes
Feb 19, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: DavidGOrtega [email protected] for parallel download