[Relax] Fix Torch frontends to report all the missing ops #17826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mshr-h
approved these changes
Apr 14, 2025
Contributor
|
We can put the both check logic into |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* enhance missing func types finding in exported program and fx graph frontend * fix trailing space issue * fix lint issues by formatting the code * fix name error in fx frontend --------- Co-authored-by: deivanayakisankaralingam <deiva@Deivanayaki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error handling in from_fx and from_exported_program to detect unsupported ops more effectively. Instead of stopping at the first missing op due to an assertion error, it now collects all missing function-type ops first, which helps identify all unsupported operations at once.