[CI][Caffe Frontend] Change the caffe deps into SSD distribution #9060
Conversation
| apt-get install -y --no-install-recommends libboost-filesystem-dev libboost-python-dev \ | ||
| libboost-system-dev libboost-thread-dev libboost-regex-dev protobuf-compiler \ | ||
| libprotobuf-dev libhdf5-serial-dev libopenblas-dev libgflags-dev libgoogle-glog-dev | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Those packages are the minimum requirement for building caffe from source.
So I put them.
There was a problem hiding this comment.
the rm -rf /var/lib/apt/lists/* part seems a little weird. can you elaborate/link to these instructions?
There was a problem hiding this comment.
That's just a best practice for Dockerfiles.
Best practices for writing Dockerfiles | Docker Documentation
It might be unnecessary for this script. I'll remove it.
There was a problem hiding this comment.
ah, didn't know this but it definitely makes sense. it wasn't the convention we were using before, but we should adopt it. i've filed #9825 to track this.
| apt-get install -y --no-install-recommends libboost-filesystem-dev libboost-python-dev \ | ||
| libboost-system-dev libboost-thread-dev libboost-regex-dev protobuf-compiler \ | ||
| libprotobuf-dev libhdf5-serial-dev libopenblas-dev libgflags-dev libgoogle-glog-dev | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
the rm -rf /var/lib/apt/lists/* part seems a little weird. can you elaborate/link to these instructions?
|
|
||
| apt-get install caffe-cpu -y | ||
| # install python packages | ||
| pip install "numpy>=1.7.1" |
There was a problem hiding this comment.
can you add these to python/gen_requirements.py? also, can you use just one pip command to do this?
| mkdir /caffe_src/build && cd /caffe_src/build | ||
| cmake .. -DCMAKE_INSTALL_PREFIX=${CAFFE_HOME} -DCMAKE_BUILD_TYPE=Release -DCPU_ONLY=1 \ | ||
| -Dpython_version=3 -DUSE_OPENCV=OFF -DUSE_LEVELDB=OFF -DUSE_LMDB=OFF -DBUILD_docs=OFF -DBLAS=open | ||
| make all -j`nproc` |
There was a problem hiding this comment.
should this $(expr $(nproc) - 1) to avoid overloading systems when running docker/build.sh?
mshr-h
requested review from
comaniac,
icemelon,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
…che#9060) * Change the caffe deps into SSD distribution * update make flag * remove `rm -rf /var/lib/apt/lists/*` * install all python packages in one pip command * install latest package version * add caffe-frontend dependencies
…che#9060) * Change the caffe deps into SSD distribution * update make flag * remove `rm -rf /var/lib/apt/lists/*` * install all python packages in one pip command * install latest package version * add caffe-frontend dependencies
4 participants
This an update for #6023.
@fernchen @zhiics @tqchen @FrozenGene
Can you take a look at this PR, please? Thanks!