Skip to content

Conversation

@michalpiszczek
Copy link
Contributor

@michalpiszczek michalpiszczek commented Dec 9, 2021

  • Add a TOPI implementation of batch norm so it can be constant folded
  • Add associated tests

@michalpiszczek
Copy link
Contributor Author

@mbrookhart PTAL

@michalpiszczek
Copy link
Contributor Author

@AndrewZhaoLuo @jwfromm PTAL

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a problem with the relay test, but otherwise it looks fantastic. Thank you!

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbrookhart mbrookhart merged commit cb34604 into apache:main Dec 13, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants