Skip to content

Conversation

@smyrick
Copy link
Member

@smyrick smyrick commented Jun 3, 2020

See the release notes: https://github.com/graphql-java/graphql-java/releases/tag/v15.0

@ruibritopt
Copy link

Hello could the community persuade the codeowners to merge this PR? @smyrick put in the work and I for one can make great use of it, so I would really appreciate it if we could have a release soon. Thank you.

@nihalgonsalves
Copy link

nihalgonsalves commented Jun 22, 2020

@sachindshinde could you please take a look at this? It's blocking us from upgrading. Thanks!

@sachindshinde sachindshinde self-requested a review June 22, 2020 17:58
@sachindshinde
Copy link
Contributor

sachindshinde commented Jun 22, 2020

@smyrick @nihalgonsalves Sorry for the delays here, I'll review the PR

@nikolayandr
Copy link

Guys, would be really nice to have this MR merged, it stops us to upgrade on graphql-java#15

@kosmos
Copy link

kosmos commented Jun 26, 2020

Please, merge MR.

@nikolayandr
Copy link

@sachindshinde could you please tell us about plans when this MR is going to be merged? Thanks

@sachindshinde
Copy link
Contributor

@smyrick @nihalgonsalves @nikolayandr @kosmos
Apologies for the wait here.

Updates to FederationSdlPrinter need to be handled in a particular way when doing graphql-java upgrades. Specifically, the newer version of SchemaPrinter needs to be copied over FederationSdlPrinter, and then the changeset that was applied to the older version of SchemaPrinter to turn it into FederationSdlPrinter needs to be replayed on top of the newer version of SchemaPrinter (with any now-unneeded bugfix backports removed). This is done to ensure any bugfixes and subtle changes reflected in the newer SchemaPrinter are included in FederationSdlPrinter (e.g. the bugfix at graphql-java/graphql-java#1832 ).

I've iterated on this PR, and filed PR #73 . Review shouldn't take long, although we'd like to test an RC in Apollo's infrastructure first before making a release, as this has caught bugs in the past.

@smyrick smyrick deleted the graphql-java-15 branch June 27, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants