Skip to content

Conversation

@sachindshinde
Copy link
Contributor

@sachindshinde sachindshinde commented Jun 27, 2020

This PR is an iteration of the changes suggested in #67 (many thanks to the authors and commenters).

Summary of Changes:

Note that this is a backwards incompatible change due to backwards incompatible changes in graphql-java v15's SchemaPrinter.

It'll be easier in this PR to go commit-by-commit. For FederationSdlPrinter, it'll help to compare FederationSdlPrinter.java in the class-copy-and-rename commit to the v15 SchemaPrinter, located at https://raw.githubusercontent.com/graphql-java/graphql-java/v15.0/src/main/java/graphql/schema/idl/SchemaPrinter.java . For the FederationSdlPrinter changes that fix the issue in #53 , it'll help to compare against the respective changes in that PR.

@sachindshinde
Copy link
Contributor Author

Note that we should test this in our own Apollo infra before releasing

<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ExternalStorageConfigurationManager" enabled="true" />
<component name="JavaScriptSettings">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IntelliJ's been adding that in for a while, no clue why it keeps doing that (maybe it's because of plugins?).

@sachindshinde sachindshinde force-pushed the sachin/graphql-java-v15 branch from a302e32 to 9cd7f67 Compare June 30, 2020 18:29
@sachindshinde sachindshinde force-pushed the sachin/graphql-java-v15 branch from 9cd7f67 to 8f13bfc Compare July 1, 2020 18:41
@sachindshinde sachindshinde merged commit c2dce86 into master Jul 1, 2020
@sachindshinde sachindshinde deleted the sachin/graphql-java-v15 branch July 1, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants