-
Notifications
You must be signed in to change notification settings - Fork 68
graphql-java-support: Bump graphql-java to v15 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that we should test this in our own Apollo infra before releasing |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="ExternalStorageConfigurationManager" enabled="true" /> | ||
| <component name="JavaScriptSettings"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My IntelliJ's been adding that in for a while, no clue why it keeps doing that (maybe it's because of plugins?).
a302e32 to
9cd7f67
Compare
…o disclude the backfix porting
…ch was removed from v15
…a, which was removed from v15
9cd7f67 to
8f13bfc
Compare
This PR is an iteration of the changes suggested in #67 (many thanks to the authors and commenters).
Summary of Changes:
graphql-javato v15 in thepom.xmlenforceSchemaDirectives(true)fromFederation.javatrue(thankfully we've already done the legwork to not have to worry about this)includeExtendedScalarTypes(true)fromSchemaTransformer.javatrue(what were previously known as "extended scalars" ingraphql-javaare now just regular custom scalars)@specifiedByto standard directive listsgraphql-javain add custom scalar Specification URL graphql-java/graphql-java#1772 with the spec addition still pending at [RFC] Custom Scalar Specification URIs graphql/graphql-spec#635@specifiedBywith federation will not be able to do so, since federation SDL won't expose the directive definition and the directive definitions the gateway introduces may not have it.)FederationSdlPrinterto usegraphql-javav15'sSchemaPrinterNote that this is a backwards incompatible change due to backwards incompatible changes in
graphql-javav15'sSchemaPrinter.It'll be easier in this PR to go commit-by-commit. For
FederationSdlPrinter, it'll help to compareFederationSdlPrinter.javain the class-copy-and-rename commit to the v15SchemaPrinter, located at https://raw.githubusercontent.com/graphql-java/graphql-java/v15.0/src/main/java/graphql/schema/idl/SchemaPrinter.java . For theFederationSdlPrinterchanges that fix the issue in #53 , it'll help to compare against the respective changes in that PR.